Add support multiple agent pool profiles

[titilambert]

Hello,

This small patch, enable multi agent pool profiles. It lets users put multiple agent_pool_profile blocks

resource "azurerm_kubernetes_cluster" "aks" {
  ...
  agent_pool_profile {
     name  = "Linux"
      ...
  }
  agent_pool_profile {
     name  = "Windows"
      ...
  }
  ...
}

[dominik-lekse]

@titilambert Thanks for this. Could you add a test case covering multiple agent_pool_profile blocks. I would keep it simple in the beginning and use two Linux based agent pools.

[katbyte]

Hi @titilambert,

Thanks for the PR. Addition to what @dominik-lekse mentioned, you will also need to update the flatten function & documentation.

[djsly]

@dominik-lekse / @katbyte , we will be tackling the Windows Agent Pool right after, do you know if there is some work in progress ? WE looked but couldn't find it.

[djsly]

#3478
#3493

[titilambert]

Hi @titilambert,

Thanks for the PR. Addition to what @dominik-lekse mentioned, you will also need to update the flatten function & documentation.

Which flatten function are you talking about ? this one flattenKubernetesClusterAgentPoolProfiles ? If so, It's already multiple profile compatible

[tombuildsstuff]

@titilambert

Which flatten function are you talking about ? this one flattenKubernetesClusterAgentPoolProfiles ? If so, It's already multiple profile compatible

Agreed the flatten function's fine here - aside from a missing acceptance test with multiple node pools (example) and updating the documentation to remove the limitation) this otherwise LGTM 👍

[titilambert]

Test added

[titilambert]

Doc added

[titilambert]

Should I patch azurerm/data_source_kubernetes_cluster.go ?

[tombuildsstuff]

hey @titilambert

Thanks for pushing those changes - taking a look through, besides removing one comment in the documentation (so that multiple node pools are now allowed, which I hope you don't mind but I'll push a commit for) - this now LGTM 👍

Thanks!

dismissing since changes have been pushed

[tombuildsstuff]

Ignoring some known/transitory test failures - the tests pass:

[ghost]

This has been released in version 1.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.29.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!