-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions to azurerm_key_vault
#348
Conversation
Tests pass. Data Source:
Key Vault:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming all relevant acceptance tests are passing.
string(keyvault.Managecontacts), | ||
string(keyvault.Manageissuers), | ||
string(keyvault.Setissuers), | ||
string(keyvault.Update), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if there's an array/slice of all permissions, so that we don't need to update this list after Azure introduces new ones. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's exposed as a collection of Constants, so it might be hard in the short term - however we could ask the SDK team to expose that as a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you, it's no big deal - I just thought it may save us some pain/work in the future.
Feel free to 🚢 it as is.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Adding the missing fields:
application_id
certificate_permissions
Also added
application_id
to theazurerm_client_config
data source as it was neededFixes #48