Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to azurerm_key_vault #348

Merged
merged 3 commits into from
Sep 25, 2017
Merged

Additions to azurerm_key_vault #348

merged 3 commits into from
Sep 25, 2017

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Sep 20, 2017

Adding the missing fields:

  • application_id
  • certificate_permissions

Also added application_id to the azurerm_client_config data source as it was needed

Fixes #48

@tombuildsstuff
Copy link
Contributor Author

Tests pass.

Data Source:

 $ acctests azurerm TestAccDataSourceAzureRMClientConfig_
=== RUN   TestAccDataSourceAzureRMClientConfig_basic
--- PASS: TestAccDataSourceAzureRMClientConfig_basic (10.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	10.831s

Key Vault:

$ acctests azurerm TestAccAzureRMKeyVault_
=== RUN   TestAccAzureRMKeyVault_importBasic
--- PASS: TestAccAzureRMKeyVault_importBasic (75.21s)
=== RUN   TestAccAzureRMKeyVault_name
--- PASS: TestAccAzureRMKeyVault_name (0.00s)
=== RUN   TestAccAzureRMKeyVault_basic
--- PASS: TestAccAzureRMKeyVault_basic (66.83s)
=== RUN   TestAccAzureRMKeyVault_complete
--- PASS: TestAccAzureRMKeyVault_complete (76.32s)
=== RUN   TestAccAzureRMKeyVault_update
--- PASS: TestAccAzureRMKeyVault_update (101.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	319.903s

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming all relevant acceptance tests are passing.

string(keyvault.Managecontacts),
string(keyvault.Manageissuers),
string(keyvault.Setissuers),
string(keyvault.Update),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if there's an array/slice of all permissions, so that we don't need to update this list after Azure introduces new ones. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's exposed as a collection of Constants, so it might be hard in the short term - however we could ask the SDK team to expose that as a function?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you, it's no big deal - I just thought it may save us some pain/work in the future.
Feel free to 🚢 it as is.

@tombuildsstuff tombuildsstuff merged commit 62bf74f into master Sep 25, 2017
@tombuildsstuff tombuildsstuff deleted the keyvault branch September 25, 2017 10:11
tombuildsstuff added a commit that referenced this pull request Sep 25, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_key_vault missing access policy for ApplicationID
2 participants