Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read_scale property to sql database #3377

Merged
merged 3 commits into from
May 10, 2019

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented May 5, 2019

Adds a new property that can be used in combination with Premium and Business Critical SQL databases.

@katbyte katbyte added this to the v1.28.0 milestone May 6, 2019
@mbfrahry mbfrahry self-assigned this May 7, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @r0bnet! These changes look good, we just need to make a minor change in the docs and we're good to go

website/docs/r/sql_database.html.markdown Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @r0bnet LGTM now 👍

@katbyte katbyte merged commit fe9aa56 into hashicorp:master May 10, 2019
katbyte added a commit that referenced this pull request May 10, 2019
@r0bnet r0bnet deleted the sql-database-read-scale branch May 11, 2019 11:50
@ghost
Copy link

ghost commented May 17, 2019

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants