Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Stream Analytics properties shouldn't be required #3342

Closed
r0bnet opened this issue Apr 30, 2019 · 3 comments · Fixed by #4190
Closed

Some Stream Analytics properties shouldn't be required #3342

r0bnet opened this issue Apr 30, 2019 · 3 comments · Fixed by #4190

Comments

@r0bnet
Copy link
Contributor

r0bnet commented Apr 30, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.11.13
AzureRM: 1.26.0

Affected Resource(s)

  • azurerm_stream_analytics_job

Terraform Configuration Files

Sample code from the documentation is sufficient.

resource "azurerm_resource_group" "example" {
  name     = "example-resources"
  location = "West Europe"
}

resource "azurerm_stream_analytics_job" "example" {
  name                                     = "example-job"
  resource_group_name                      = "${azurerm_resource_group.example.name}"
  location                                 = "${azurerm_resource_group.example.location}"
  compatibility_level                      = "1.1"
  data_locale                              = "en-GB"
  events_late_arrival_max_delay_in_seconds = 60
  events_out_of_order_max_delay_in_seconds = 50
  events_out_of_order_policy               = "Adjust"
  output_error_policy                      = "Drop"
  streaming_units                          = 3

  transformation_query = <<QUERY
    SELECT *
    INTO [YourOutputAlias]
    FROM [YourInputAlias]
QUERY
}

Expected Behavior

I was hoping that properties compatibility_level, data_locale, events_late_arrival_max_delay_in_seconds, events_out_of_order_max_delay_in_seconds, events_out_of_order_policy, output_error_policy, streaming_units and transformation_query wouldn't be required. When you have a look at the ARM definition or at the API specs none of those properties are required. That means that using Terraform forces you to have more strict constraints than ARM templates or the API directly.
In my case we have a different type of deployment when it comes to the transformation query. Our developers / data engineers keep the code for the transformation query in their own repo and deploy it from time to time. If this happens and the query got updated Terraform complains with a 404 Transformation not found error when doing terraform plan. So i only want to create the bare minimum of configuration that's really needed for the job. I think the properties mentioned above shouldn't be mandatory. This wouldn't even be a breaking change since all users of this resource had to set it anyway.

Actual Behavior

Properties mentioned above are required.

@nexxai
Copy link
Contributor

nexxai commented Aug 29, 2019

Submitted PR #4190

@katbyte katbyte added this to the v1.34.0 milestone Sep 3, 2019
@katbyte katbyte self-assigned this Sep 7, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants