-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: azurerm_stream_analytics_output_eventhub does not set the output format #3318
bugfix: azurerm_stream_analytics_output_eventhub does not set the output format #3318
Conversation
d5a0362
to
0d8cb5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @maxbog,
Aside from one minor comment i've left inline this looks good
Config: testAccAzureRMStreamAnalyticsOutputEventHub_jsonArrayFormat(ri, location), | ||
Check: resource.ComposeTestCheckFunc( | ||
testCheckAzureRMStreamAnalyticsOutputEventHubExists(resourceName), | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add some checks here:
resource.TestCheckResourceAttr(resourceName, "serialization.0.format", "Array"),
and for the rest of the serialization block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done here and for all other types of serialization
0d8cb5f
to
2a62ad5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! LGTM 👍
This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.28.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
No description provided.