-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for identity attribute on container groups #3243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jplane
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can fix up the minor comments we should be able to run to run the tests and get this merged 👍
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jplane
Thanks for pushing those changes - I've run the tests but have noticed a crash when the identity
block isn't specified; if we can add a nil-check this should otherwise be good 👍
Thanks!
Good catch, sorry for that... in case its not obvious, I'm a bit of a Go newb. :-) Co-Authored-By: jplane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing those changes @jplane this now LGTM 👍
@jplane unrelated to this PR - but it appears that the Windows Server docker images have been relocated from the Docker Hub to Microsoft's Container Registry; as such I'm going to push a commit to make those tests green, I hope you don't mind :) |
reverted the Windows container changes because this is a more involved/unrelated job |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Addresses this enhancement: #3241
Fixes #3241