Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: go get github.com/hashicorp/terraform@44702fa6c163 #3181

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

apparentlymart
Copy link
Contributor

@apparentlymart apparentlymart commented Apr 5, 2019

This makes available the ConfigMode field of schema.Schema, which does nothing at all when used with Terraform v0.11, but in v0.12 allows the provider to customize how Terraform should expect the schema's value to be represented in configuration.

This is the latest SDK commit from the v0.11 branch in the Terraform Core repository. The goal here is just to make this field available so that we can merge support patches preparing for the first v0.12-compatible release without first merging the v0.12-compatible SDK.

This makes available the ConfigMode field of schema.Schema, which does
nothing at all when used with Terraform v0.11, but in v0.12 allows the
provider to customize how Terraform should expect the schema's value to
be represented in configuration.
@apparentlymart apparentlymart added dependencies upstream/terraform This issue is blocked on an upstream issue within Terraform (Terraform Core/CLI, The Plugin SDK etc) labels Apr 5, 2019
@apparentlymart apparentlymart self-assigned this Apr 5, 2019
@apparentlymart apparentlymart requested a review from a team April 5, 2019 00:27
@ghost ghost added the size/XXL label Apr 5, 2019
@tombuildsstuff tombuildsstuff added this to the v1.25.0 milestone Apr 5, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 731946e into master Apr 5, 2019
@tombuildsstuff tombuildsstuff deleted the deps-tf-sdk-configmode branch April 5, 2019 06:03
tombuildsstuff added a commit that referenced this pull request Apr 5, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies size/XXL upstream/terraform This issue is blocked on an upstream issue within Terraform (Terraform Core/CLI, The Plugin SDK etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants