Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove minItem for zone in VMSS #3142

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

Lucretius
Copy link
Contributor

Resolves #1787

A search of the repo found that only VMSS was using this helper. I also noticed that expandZones - the helper for the zones, returns nil if the length is 0, so an empty array will work out of the box. I added the empty array to the basic VMSS test. Not sure I am running the make testacc incorrectly but trying to regex just the basic test ended up firing all tests which began with TestAccAzureRMVirtualMachineScaleSet_basic in the name which caused throttling limits. I thought this flag could take a regex like TestAccAzureRMVirtualMachineScaleSet_basic$?

@ghost ghost added the size/XS label Mar 28, 2019
@tombuildsstuff tombuildsstuff added enhancement service/vmss Virtual Machine Scale Sets labels Mar 29, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lucretius, LGTM 👍

@katbyte katbyte added this to the v1.24.0 milestone Apr 1, 2019
@katbyte katbyte merged commit 68a2ec8 into hashicorp:master Apr 1, 2019
katbyte added a commit that referenced this pull request Apr 1, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/vmss Virtual Machine Scale Sets size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_machine_scale_set: allow empty zone specification
3 participants