Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_api_management_api_operation #3121

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR introduces a new resource for API Management Operations, as a part of #1177

After spending /a long time/ with the nested sets, I ended up porting most elements (header, response etc) to Lists, since the API appears to be consistent in it's ordering which is helpful to avoid 3-level deep nested sets. There's also a TODO here to add an additional acceptance test when API Management Schema's are supported, but it's fine for now.

Tests pass:

Screenshot 2019-03-26 at 11 23 08

Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contentTypeIsFormData := strings.EqualFold(contentType, "multipart/form-data") || strings.EqualFold(contentType, "application/x-www-form-urlencoded")

// Representation formParameters can only be specified for form data content types (multipart/form-data, application/x-www-form-urlencoded)
if contentTypeIsFormData {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat approach to block-wide validations!

@tombuildsstuff tombuildsstuff merged commit 0f75b5f into master Mar 26, 2019
@tombuildsstuff tombuildsstuff deleted the f/api-management-operations branch March 26, 2019 12:22
tombuildsstuff added a commit that referenced this pull request Mar 26, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants