Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zone_redundant as editable flag for mssql_elasticpool #3104

Merged

Conversation

bs-matil
Copy link
Contributor

Hi,
we need zone_redundant elastic pools and therefore implemented the flag on the mssql_elasticpool resource.

Feel free to add any comments.

@bs-matil bs-matil force-pushed the add-zone_redundant-for-mssql_elasticpool branch from 46b705e to b434b8a Compare March 22, 2019 12:00
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bs-matil,

Thank you for the PR. I think we need to conditionally send the value to the API (see my comment for more details). Other then that i think this is looking pretty good.

azurerm/resource_arm_mssql_elasticpool_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool.go Outdated Show resolved Hide resolved
@bs-matil bs-matil force-pushed the add-zone_redundant-for-mssql_elasticpool branch from 1dd2394 to 336bd17 Compare March 27, 2019 20:43
@bs-matil
Copy link
Contributor Author

@katbyte I now embedded all requested changes.

@ghost ghost removed the waiting-response label Mar 27, 2019
@@ -92,14 +92,14 @@ The following arguments are supported:

---

* `zone_redundant` - (Optional) Whether or not this elastic pool is zone redundant. `tier` needs to be `Premium` for `DTU` based or `BusinessCritical` for `vCore` based `sku`. Defaults to `false`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte should we leave the Defaults to false here? As its the API behavior anyways its still may a fair hint?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave it as yes that is what the api does by default.

@bs-matil bs-matil force-pushed the add-zone_redundant-for-mssql_elasticpool branch from 336bd17 to 41884d4 Compare March 27, 2019 21:07
@bs-matil bs-matil force-pushed the add-zone_redundant-for-mssql_elasticpool branch from 41884d4 to 7dc548f Compare March 27, 2019 21:09
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes so quickly!

LGTM 🙂

@@ -92,14 +92,14 @@ The following arguments are supported:

---

* `zone_redundant` - (Optional) Whether or not this elastic pool is zone redundant. `tier` needs to be `Premium` for `DTU` based or `BusinessCritical` for `vCore` based `sku`. Defaults to `false`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave it as yes that is what the api does by default.

@katbyte katbyte added this to the v1.24.0 milestone Mar 27, 2019
@katbyte katbyte merged commit 22d56a8 into hashicorp:master Mar 27, 2019
katbyte added a commit that referenced this pull request Mar 27, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants