Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventhub property skip empty archives #3074

Merged

Conversation

Lucretius
Copy link
Contributor

@Lucretius Lucretius commented Mar 19, 2019

Resolves #3057

Two questions

  1. I've altered the event hub tests to use a fully-configurable capture description (in case we want to expand on test cases later on down the road). I first tried just re-created the capture description struct to match the struct in the resource itself, then I pulled in the github.com/Azure/azure-sdk-for-go/services/eventhub/mgmt/2017-04-01/eventhub dependency and relied directly on the source models. Which is best practice? (Opted to simplify testing for sake of ease-of-understanding)

  2. The field itself is a bit hard to describe without using a double negative. The SDK referred to it as SkipEmptyArchives, which will not emit empty files if no events occur in the capture window. Any suggestions for verbiage or this is easy enough to read?

Feel free to review and I can adjust accordingly.

@ghost ghost added size/XS and removed size/M labels Mar 20, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Lucretius, while not ideal the property matches the SDK/API and most likely the docs online so i think it's fine as is 🙂 LGTM 👍

@katbyte katbyte added this to the v1.24.0 milestone Mar 21, 2019
@katbyte katbyte merged commit b5af16d into hashicorp:master Mar 21, 2019
katbyte added a commit that referenced this pull request Mar 21, 2019
@Lucretius Lucretius deleted the eventhub-property-skip-empty-archives branch March 21, 2019 06:57
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 20, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Azure Event Hub - Add 'Do not emit empty files' option
3 participants