-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark maxTasksPerNode as forcenew #2856
Mark maxTasksPerNode as forcenew #2856
Conversation
The maxTasksPerNode cannot be changed once a Batch pool has been created so marking as ForceNew to require re-creating the pool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @stuartleeks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @stuartleeks,
LGTM aside from could the documentation be updated to reflect this?
hey @stuartleeks Thanks again for this PR :) I hope you don't mind but I've pushed a commit to update the documentation so that we can get this merged 👍 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 👍
Thank you! It was on my list but unfortunately I didn't get chance to look at it this week. |
This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.23.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
The maxTasksPerNode cannot be changed once a Batch pool has been created
so marking as ForceNew to require re-creating the pool