azurerm_app_service: Adds authentication support

[joakimhew]

This PR fixes #1992 and allows users to configure authentication for azurerm_app_service. This PR supports all of the providers in azure (Active Directory, Facebook, Google, Microsoft, Twitter).

It uses the UpdateAuthSetting as mentioned in the issue. More information about the API here: Web Apps - Update Auth Settings

Each provider is defined in it's own block inside of an auth_settings section.
Example:

auth_settings {
  enabled                       = true
  issuer                        = "https://sts.windows.net/d13958f6-b541-4dad-97b9-5a39c6b01297"
  default_provider              = "AzureActiveDirectory"
  unauthenticated_client_action = "RedirectToLoginPage"

  active_directory {
    client_id     = "aadclientid"
    client_secret = "aadsecret"

    allowed_audiences = [
      "someallowedaudience",
    ]
  }
    
  microsoft {
    client_id     = "microsoftclientid"
    client_secret = "microsoftclientsecret"

    oauth_scopes = [
      "somescope",
    ]
  }
}

[a144359]

can we do this for Azure function app as well? Looks like much of the changes are applicable to functions_app

[joakimhew]

@a144359 I'll look into this 👍

[tombuildsstuff]

@joakimhew sorry for the delay reviewing this PR (I'd missed this hadn't been reviewed) - I'm taking a look now

[joakimhew]

@tombuildsstuff Thank you buddy. I can see that there are a couple of conflicts now as it's been a while. I'll wait for your review before I resolve those conflicts! 😄

[tombuildsstuff]

hey @joakimhew

Thanks for this PR - apologies for the delayed review here, I'd got most of the way through this and then forgot to hit submit, so I've taken a fresh look this morning.

On the whole this looks pretty good - if we can fix up the comments (and resolve the merge conflicts) this otherwise LGTM 👍

Thanks!

[joakimhew]

@tombuildsstuff Thank you for the review Tom. I'll try to get by it this week! 👍

[joakimhew]

@tombuildsstuff I've resolved your requested changes and hopefully it's good to go now 👍

[tombuildsstuff]

hey @joakimhew

Thanks for pushing those changes - taking a look through besides some minor documentation tweaks (to ensure this matches the other resources, which I hope you don't mind but I'm going to push a commit for) - this LGTM 👍

Thanks!

[joakimhew]

@tombuildsstuff Wonderful, thank you for resolving the documentation stuff. And as always, thanks for the amount of work you put into reviewing this! 😄

[tombuildsstuff]

@joakimhew anytime :) the tests identified a couple more minor things, which I've pushed a commit to fix

[tombuildsstuff]

Tests pass:

Thanks again @joakimhew :)

[ghost]

This has been released in version 1.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.29.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!