Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotpatch support for Windows Server 2025 #28141

Closed
1 task done
JacekKossowski opened this issue Nov 29, 2024 · 1 comment · Fixed by #28160
Closed
1 task done

Hotpatch support for Windows Server 2025 #28141

JacekKossowski opened this issue Nov 29, 2024 · 1 comment · Fixed by #28160

Comments

@JacekKossowski
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Terraform Version

1.9.8

AzureRM Provider Version

4.12.0

Affected Resource(s)/Data Source(s)

azurerm_windows_virtual_machine

Terraform Configuration Files

resource "azurerm_windows_virtual_machine" "main" {
  name                = "${var.prefix}-vm"
  resource_group_name = azurerm_resource_group.main.name
  location            = azurerm_resource_group.main.location
  size                = "Standard_F2s_v2"
  admin_username      = "adminuser"
  admin_password      = "P@ssw0rd1234!"

  network_interface_ids = [
    azurerm_network_interface.main.id,
  ]

  os_disk {
    caching              = "ReadWrite"
    storage_account_type = "Standard_LRS"
  }

  source_image_reference {
    publisher = "MicrosoftWindowsServer"
    offer     = "WindowsServer"
    sku = "2025-datacenter-azure-edition"
    version   = "latest"
  }

  patch_mode          = "AutomaticByPlatform"
  hotpatching_enabled = true
}

Debug Output/Panic Output

When trying to deploy server with SKU to WS 2025 datacenter azure edition an error happens

Expected Behaviour

Windows Server 2025 should be supported

Actual Behaviour

Error: "hotpatching_enabled" is currently only supported on "2022-datacenter-azure-edition-core", "2022-datacenter-azure-edition-core-smalldisk", "2022-datacenter-azure-edition-hotpatch" or "2022-datacenter-azure-edition-hotpatch-smalldisk" image reference skus

Steps to Reproduce

regular plan and apply with sku mentioned above.

Important Factoids

No response

References

No response

@github-actions github-actions bot added the v/4.x label Nov 29, 2024
@JacekKossowski
Copy link
Author

Seems that to allow this functionality 3 lines of code needs to be changed:
terraform-provider-azurerm/internal/services/compute/shared_schema.go line 644 to accomodate for 4 new SKUs
terraform-provider-azurerm/internal/services/compute/windows_virtual_machine_resource.go line 616 to reflect new SKUs in error message
terraform-provider-azurerm/internal/services/compute/orchestrated_virtual_machine_scale_set_resource.go line 556 to reflect new SKUs in error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants