Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_traffic_manager_external_endpoint - revert priority back to O+C since API increments the default value #27966

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Nov 11, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

  • Removed default and set priority back to O+C
  • Added a test case to ensure we catch any regression around expected behaviour of the priority field

Testing

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_traffic_manager_external_endpoint - the value for priority will be dynamically assigned by the API [GH-00000]
  • azurerm_traffic_manager_azure_endpoint - the value for priority will be dynamically assigned by the API [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27275

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🖥️

@stephybun stephybun merged commit 3f76396 into main Nov 12, 2024
32 of 34 checks passed
@stephybun stephybun deleted the b/revert-default-on-priority branch November 12, 2024 09:01
@github-actions github-actions bot added this to the v4.10.0 milestone Nov 12, 2024
stephybun added a commit that referenced this pull request Nov 12, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants