azurerm_logic_app_standard - update resource to use go-azure-sdk and add public_network_access

[stephybun]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

• Updates the Logic App Standard resource to use hashicorp/go-azure-sdk
• adds the public_network_access property on the site properties level in both the resource and the data source
• fixes the half baked documentation for resource and data source
• To handle the behaviour described below the site_config.public_network_access_enabled property has been deprecated and public_network_access will control setting this on the site properties as well as the site_config level of the resource

The site_config.public_network_access_enabled and public_network_access properties are intertwined
My observations are:

• setting site_config.public_network_access_enabled will also set public_network_access
• setting public_network_access will not set site_config.public_network_access_enabled
• site_config.public_network_access_enabled can be updated (as in API will return whatever value we send to it)
• public_network_access can not be updated

Testing

4.x mode:

5.0 mode:

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_logic_app_standard - add support for the public_network_access property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #23809
Supersedes #24842

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[premaarya]

We are waiting for this feature/bug fix, any idea how long we need to wait for it to available?

[mbfrahry]

LGTM

[jackofallops]

Thanks @stephybun - just a couple minor things to check, but otherwise LGTM 🦦