Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_subnet: Remove ForceNew from default_outbound_access_enabled property. #27858

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

CorrenSoft
Copy link
Contributor

@CorrenSoft CorrenSoft commented Nov 1, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Removed ForceNew flag from default_outbound_access_enabled property.
Updated TestAccSubnet_defaultOutbound to evaluate the update on the property.

Notes:

  • The documentation has not been updated as it does not describe the property as Force Recreation.
  • This change is not required in azurerm_virtual_network resource, since it is already supporting the update without recreation.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
make acctests  SERVICE='network' TESTARGS='-run=TestAccSubnet_defaultOutbound'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run=TestAccSubnet_defaultOutbound -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSubnet_defaultOutbound
=== PAUSE TestAccSubnet_defaultOutbound
=== CONT  TestAccSubnet_defaultOutbound
--- PASS: TestAccSubnet_defaultOutbound (312.60s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       312.871s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27848

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Updated TestAccSubnet_defaultOutbound to evaluate the update on the property.
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CorrenSoft LGTM 👍

@stephybun stephybun merged commit 8766b56 into hashicorp:main Nov 4, 2024
28 of 29 checks passed
@github-actions github-actions bot added this to the v4.9.0 milestone Nov 4, 2024
stephybun added a commit that referenced this pull request Nov 4, 2024
@CorrenSoft CorrenSoft deleted the feature/27848 branch November 4, 2024 12:49
Copy link

github-actions bot commented Dec 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching default_outbound_access_enabled from true to false for azurerm_subnet forces replacement
2 participants