azurerm_mssql_managed_database - support for tags #27857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbfrahry
approved these changes
Nov 1, 2024
| @@ -157,15 +161,15 @@ func (r MsSqlManagedDatabaseResource) Create() sdk.ResourceFunc { | |||
| parameters := manageddatabases.ManagedDatabase{ | |||
| Location: managedInstance.Model.Location, | |||
| Properties: &manageddatabases.ManagedDatabaseProperties{}, | |||
| Tags: &model.Tags, | |||
There was a problem hiding this comment.
Suggested change
| Tags: &model.Tags, | |
| Tags: pointer.To(model.Tags), |
| @@ -233,6 +238,17 @@ func (r MsSqlManagedDatabaseResource) Update() sdk.ResourceFunc { | |||
|
|
|||
| d := metadata.ResourceData | |||
|
|
|||
| if d.HasChange("tags") { | |||
| parameters := manageddatabases.ManagedDatabase{ | |||
| Tags: &model.Tags, | |||
There was a problem hiding this comment.
Suggested change
| Tags: &model.Tags, | |
| Tags: pointer.To(model.Tags), |
| @@ -319,6 +335,10 @@ func (r MsSqlManagedDatabaseResource) Read() sdk.ResourceFunc { | |||
| model.PointInTimeRestore = flattenManagedDatabasePointInTimeRestore(v) | |||
| } | |||
|
|
|||
| if model.Tags != nil { | |||
| state.Tags = model.Tags | |||
There was a problem hiding this comment.
You could get rid of this block and just do state.Tags = pointer.From(model.Tags)
rcskosir
added
enhancement
service/mssql
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_mssql_managed_database - support for tags [GH-00000]
This is a (please select all that apply):
Related Issue(s)
Fixes #27809
Note
If this PR changes meaningfully during the course of review please update the title and description as required.