azurerm_application_gateway: add connection draining

[SteveByerly]

Add Connection Draining to the Application Gateway backend_http_settings.

Addresses topics referenced in #1519 and #1576

Please note:
I am not very familiar with Go. I was also unable to properly run the tests. Any and all feedback/help is appreciated.

[SteveByerly]

@tombuildsstuff i see Travis passed, but did it actually run all the tests? Seems like the output has been consistent since the beginning of the repo

[katbyte]

Hi @SteveByerly,

Thank you for the PR, i've taken a look and left some comments inline. In addition could we get the documentation updated with the new properties?

And wrt the tests, travis only runs local tests and some linting, acceptance tests are all done separate on our CI server as they spin up real resources that cost money. We usually run these ourselves before merging

[tombuildsstuff]

hey @SteveByerly

Thanks for this PR :)

I've taken a look through and left a couple of comments in addition to @katbyte's - but this is looking good. If we can fix those up we should be able to run the test suite and get this merged 👍

Thanks!

[katbyte]

Hi @SteveByerly,

I hope you don't mind but to get this merged I pushed the requested changes to your branch 🙂 Once the test pass this is now good to merge!

[tombuildsstuff]

otherwise LGTM 👍

[katbyte]

Hi @SteveByerly,

While running the tests i am getting the following failure on all the gateway tests:

------- Stdout: -------
=== RUN   TestAccAzureRMApplicationGateway_webApplicationFirewall
=== PAUSE TestAccAzureRMApplicationGateway_webApplicationFirewall
=== CONT  TestAccAzureRMApplicationGateway_webApplicationFirewall
--- FAIL: TestAccAzureRMApplicationGateway_webApplicationFirewall (1290.68s)
    testing.go:538: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        UPDATE: azurerm_application_gateway.test
          backend_http_settings.0.protocol: "" => "Http"

Once those failures are fixed we can get this merged 🙂

[tombuildsstuff]

hey @SteveByerly

I hope you don't mind that I've pushed a commit to fix the broken test that @katbyte raised, but this now otherwise LGTM 👍

Thanks!

[tombuildsstuff]

Tests pass:

[SteveByerly]

@katbyte @tombuildsstuff thanks for all the help!

[ghost]

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!