Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_security_center_subscription_pricing - correctly type assert additional properties #27721

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Oct 22, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The type of additionalProperties changed in the SDK which meant we were not type asserting and transforming this properly before setting it into the payload.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

Testing

Test results in TC are flaky since these tests don't appear to be run sequentially, test results are from a local run.

=== RUN   TestAccSecurityCenterSubscriptionPricing_cloudPosture
=== RUN   TestAccSecurityCenterSubscriptionPricing_cloudPosture/securityCenterSubscriptionPricing
=== RUN   TestAccSecurityCenterSubscriptionPricing_cloudPosture/securityCenterSubscriptionPricing/standardToFree
=== RUN   TestAccSecurityCenterSubscriptionPricing_cloudPosture/securityCenterSubscriptionPricing/freeToStandard
=== RUN   TestAccSecurityCenterSubscriptionPricing_cloudPosture/securityCenterSubscriptionPricing/basic
--- PASS: TestAccSecurityCenterSubscriptionPricing_cloudPosture (179.41s)
    --- PASS: TestAccSecurityCenterSubscriptionPricing_cloudPosture/securityCenterSubscriptionPricing (179.41s)
        --- PASS: TestAccSecurityCenterSubscriptionPricing_cloudPosture/securityCenterSubscriptionPricing/standardToFree (58.99s)
        --- PASS: TestAccSecurityCenterSubscriptionPricing_cloudPosture/securityCenterSubscriptionPricing/freeToStandard (47.69s)
        --- PASS: TestAccSecurityCenterSubscriptionPricing_cloudPosture/securityCenterSubscriptionPricing/basic (72.74s)
=== RUN   TestAccSecurityCenterSubscriptionPricing_storage
=== RUN   TestAccSecurityCenterSubscriptionPricing_storage/securityCenterSubscriptionPricing
=== RUN   TestAccSecurityCenterSubscriptionPricing_storage/securityCenterSubscriptionPricing/subplan
=== RUN   TestAccSecurityCenterSubscriptionPricing_storage/securityCenterSubscriptionPricing/defender
--- PASS: TestAccSecurityCenterSubscriptionPricing_storage (65.66s)
    --- PASS: TestAccSecurityCenterSubscriptionPricing_storage/securityCenterSubscriptionPricing (65.66s)
        --- PASS: TestAccSecurityCenterSubscriptionPricing_storage/securityCenterSubscriptionPricing/subplan (32.71s)
        --- PASS: TestAccSecurityCenterSubscriptionPricing_storage/securityCenterSubscriptionPricing/defender (32.95s)
=== RUN   TestAccSecurityCenterSubscriptionPricing_update
--- PASS: TestAccSecurityCenterSubscriptionPricing_update (23.57s)
=== RUN   TestAccSecurityCenterSubscriptionPricing_cosmosDbs
--- PASS: TestAccSecurityCenterSubscriptionPricing_cosmosDbs (25.67s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/securitycenter        296.531s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_security_center_subscription_pricing - correctly type assert additional_extension_properties before setting it into the payload [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27704

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@stephybun stephybun force-pushed the b/security-pricing-additional-props branch from 7c7c824 to e0f8111 Compare October 22, 2024 11:47
@rcskosir rcskosir added the bug label Oct 22, 2024
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM 🐿️

@stephybun stephybun merged commit 9be0873 into main Oct 31, 2024
30 checks passed
@stephybun stephybun deleted the b/security-pricing-additional-props branch October 31, 2024 09:20
@github-actions github-actions bot added this to the v4.8.0 milestone Oct 31, 2024
stephybun added a commit that referenced this pull request Oct 31, 2024
Copy link

github-actions bot commented Dec 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants