-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_stack_hci_virtual_hard_disk
#27474
Conversation
…m into stackhci_virtual_hard_disk
azurerm_stackhci_virtual_hard_disk
azurerm_stack_hci_virtual_hard_disk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @teowa,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍
"custom_location_id": { | ||
Type: pluginsdk.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
ValidateFunc: customlocations.ValidateCustomLocationID, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"custom_location_id": { | |
Type: pluginsdk.TypeString, | |
Required: true, | |
ForceNew: true, | |
ValidateFunc: customlocations.ValidateCustomLocationID, | |
}, | |
"custom_location_id": commonschema.ResourceIDReferenceRequiredForceNew(&customlocations.CustomLocationId{}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
}) | ||
} | ||
|
||
func TestAccStackHCIVirtualHardDisk_update(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it only tests add/remove tags
. Could you also test update tags
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Hi @ms-zhenhua , thanks for reviewing this, I have updated the code, please kindly take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @teowa , thank you for the update. LGTM~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍
internal/services/azurestackhci/stack_hci_virtual_hard_disk_resource_test.go
Show resolved
Hide resolved
internal/services/azurestackhci/stack_hci_virtual_hard_disk_resource.go
Outdated
Show resolved
Hide resolved
internal/services/azurestackhci/stack_hci_virtual_hard_disk_resource.go
Outdated
Show resolved
Hide resolved
azurerm_stack_hci_virtual_hard_disk
azurerm_stack_hci_virtual_hard_disk
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
new resource
azurerm_stack_hci_virtual_hard_disk
Azure doc: https://learn.microsoft.com/en-us/azure-stack/hci/manage/manage-arc-virtual-machine-resources?tabs=azurecli#add-a-data-disk
swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/stable/2024-01-01/virtualHardDisks.json
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_stack_hci_virtual_hard_disk
This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.