azurerm_application_gateway: Adding http2

[ghostinthewires]

This PR introduces the ability to enable http2 in Azure Application Gateway (requested in #2698)

(fixes #2698)

[katbyte]

Thank you for the PR @ghostinthewires, it LGTM 🙂

[katbyte]

tests:

[19:56:25] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸add-http2-appgw$ testazure  TestAccAzureRMApplicationGateway
==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMApplicationGateway -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMApplicationGateway_basic
=== PAUSE TestAccAzureRMApplicationGateway_basic
=== RUN   TestAccAzureRMApplicationGateway_http2
=== PAUSE TestAccAzureRMApplicationGateway_http2
=== RUN   TestAccAzureRMApplicationGateway_requiresImport
--- SKIP: TestAccAzureRMApplicationGateway_requiresImport (0.00s)
    resource_arm_application_gateway_test.go:129: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureRMApplicationGateway_authCertificate
=== PAUSE TestAccAzureRMApplicationGateway_authCertificate
=== RUN   TestAccAzureRMApplicationGateway_pathBasedRouting
=== PAUSE TestAccAzureRMApplicationGateway_pathBasedRouting
=== RUN   TestAccAzureRMApplicationGateway_probes
=== PAUSE TestAccAzureRMApplicationGateway_probes
=== RUN   TestAccAzureRMApplicationGateway_sslCertificate
=== PAUSE TestAccAzureRMApplicationGateway_sslCertificate
=== RUN   TestAccAzureRMApplicationGateway_webApplicationFirewall
=== PAUSE TestAccAzureRMApplicationGateway_webApplicationFirewall
=== CONT  TestAccAzureRMApplicationGateway_basic
=== CONT  TestAccAzureRMApplicationGateway_probes
=== CONT  TestAccAzureRMApplicationGateway_webApplicationFirewall
=== CONT  TestAccAzureRMApplicationGateway_authCertificate
=== CONT  TestAccAzureRMApplicationGateway_pathBasedRouting
=== CONT  TestAccAzureRMApplicationGateway_sslCertificate
=== CONT  TestAccAzureRMApplicationGateway_http2
--- PASS: TestAccAzureRMApplicationGateway_pathBasedRouting (1111.83s)
--- PASS: TestAccAzureRMApplicationGateway_basic (1121.19s)
--- PASS: TestAccAzureRMApplicationGateway_probes (1121.75s)
--- PASS: TestAccAzureRMApplicationGateway_webApplicationFirewall (1223.14s)
--- PASS: TestAccAzureRMApplicationGateway_http2 (1283.39s)
--- PASS: TestAccAzureRMApplicationGateway_authCertificate (1426.53s)
--- PASS: TestAccAzureRMApplicationGateway_sslCertificate (1982.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1984.581s

[katbyte]

For some reason travis is not picking up on this branch? nor teamcity. Local run:

[20:30:11] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸image/deprovision-fix$ make fmt goimport build test lint
==> Fixing source code with gofmt...
# This logic should match the search logic in scripts/gofmtcheck.sh
gofmt -s -w `find . -name '*.go' | grep -v vendor`
==> Fixing imports code with goimports...
goimports -w azurerm/
==> Checking that code complies with gofmt requirements...
go install
go test -i $(go list ./... |grep -v 'vendor') || exit 1
echo $(go list ./... |grep -v 'vendor') | \
		xargs -t -n4 go test  -timeout=30s -parallel=4
go test -timeout=30s -parallel=4 github.com/terraform-providers/terraform-provider-azurerm github.com/terraform-providers/terraform-provider-azurerm/azurerm github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/kubernetes
?   	github.com/terraform-providers/terraform-provider-azurerm	[no test files]
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	5.065s
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure	1.413s
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/kubernetes	(cached)
go test -timeout=30s -parallel=4 github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/response github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/set github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/suppress github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf
?   	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/response	[no test files]
?   	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/set	[no test files]
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/suppress	1.430s
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf	(cached)
go test -timeout=30s -parallel=4 github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils github.com/terraform-providers/terraform-provider-azurerm/version
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate	0.701s
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils	1.280s
?   	github.com/terraform-providers/terraform-provider-azurerm/version	[no test files]
==> Checking source code against linters...
[21:04:15] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸image/deprovision-fix$

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!