-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set implicit condition_version
on azurerm_role_assignment
#27189
feat: set implicit condition_version
on azurerm_role_assignment
#27189
Conversation
@@ -576,8 +594,32 @@ resource "azurerm_role_assignment" "test" { | |||
role_definition_name = "Monitoring Reader" | |||
principal_id = data.azurerm_client_config.test.object_id | |||
description = "Monitoring Reader except " | |||
condition = "@Resource[Microsoft.Storage/storageAccounts/blobServices/containers:ContainerName] StringEqualsIgnoreCase 'foo_storage_container'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ContainerName
needs to change to name
or acceptence tests will fail. It looks like the attribute has changed in Azure - https://learn.microsoft.com/en-us/azure/storage/blobs/storage-auth-abac-attributes#container-name
azurerm_role_assignment
condition_version
on azurerm_role_assignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @logan-bobo LGTM 👍
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
I noticed when using condition that
condition_version
is required for resource creation. However when checking out the Microsoft documentation I noticed the following.This change it to propose that on resource creation of azurerm_role_assignment, if condition is set we implicitly set condition_version to be "2.0" as this is the default and only supported version.
This is also a revival of - #24630 however this time I have
finished all testing and this enhancement is working as I expect.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
I have added a new acceptence test for my changes to validate further.
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_role_assignment
- condition version is now optional with an implicit value of "2.0"This is a (please select all that apply):