mssql - upgrade to 2023-08-01-preview and hashicorp/go-azure-sdk
#27073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
service/mssql
catriona-m
force-pushed
the
cm/upgrademssql
branch
from
57499c8
to
81572c1
Compare
stephybun
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Thanks @catriona-m other than the comment around the potential panic LGTM 🌈
|
|
||
| d.Set("database_id", resp.DatabaseID) | ||
| if model := resp.Model; model != nil { | ||
| d.Set("location", azure.NormalizeLocation(model.Location)) |
There was a problem hiding this comment.
Should probably use
Suggested change
| d.Set("location", azure.NormalizeLocation(model.Location)) | |
| d.Set("location", location.NormalizeNilable(model.Location)) |
|
|
||
| return tags.FlattenAndSet(d, resp.Tags) | ||
| return tags.FlattenAndSet(d, resp.Model.Tags) |
There was a problem hiding this comment.
If model is nil this will panic since this is being done outside the nil check for model on line 134. Can we move this into the block where we nil check model and then return nil here instead
Suggested change
| return tags.FlattenAndSet(d, resp.Model.Tags) | |
| return nil |
…d of the successful read
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
long_term_retention_policy.immutable_backups_enabledwhich has been removed in version 2023-08-01-previewTesting
Tests passing aside from tests also failing in main