Fix missing power_state attribute value for azurerm_virtual_machine and azurerm_virtual_machine_scale_set data sources

[ned1313]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR fixes the problems identified in Issue #26990.

Currently, both the azurerm_virtual_machine and azurerm_virtual_machine_scale_set do not correctly report back the power_state attribute. The value shows up as null.

Additionally, the azurerm_virtual_machine_scale_set doesn't populate the computer_name attribute for scale sets running in Flexible orchestration mode.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Running tool: /usr/local/go/bin/go test -timeout 30s -run ^TestAccDataSourceAzureRMVirtualMachine_basicLinux$ github.com/hashicorp/terraform-provider-azurerm/internal/services/compute

ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/compute	0.024s

Running tool: /usr/local/go/bin/go test -timeout 30s -run ^TestAccDataSourceAzureRMVirtualMachine_basicWindows$ github.com/hashicorp/terraform-provider-azurerm/internal/services/compute

ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/compute	0.026s

Running tool: /usr/local/go/bin/go test -timeout 30s -run ^TestAccDataSourceVirtualMachineScaleSet_basicLinux$ github.com/hashicorp/terraform-provider-azurerm/internal/services/compute

ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/compute	0.022s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_virtual_machine data source - power_state attribute no longer null [Power State not reported in azurerm_virtual_machine and azurerm_virtual_machine_scale_set data sources #26990]
• azurerm_virtual_machine_scale_set data source - power_state and computer_name attribute no longer null [Power State not reported in azurerm_virtual_machine and azurerm_virtual_machine_scale_set data sources #26990]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #26990

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks for this PR @ned1313. Could you take a look at the suggestions left in-line? Once those are resolved I can kick off the tests.

[stephybun]

Tests looks good, thanks @ned1313 LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.