Bug fix - azurerm_express_route_connection - Remove private_link_fast_path_enabled default vaule

[xuzhang3]

The private_link_fast_path_enabled should not be added to this resource. Don't know why the API have this property in the API doc. private_link_fast_path_enabled is available the Virtual Network Gateway(ExpressRoute) but this resource(azurerm_express_route_connection) is for ExpressRouteGateway, they are different resources.

The Virtual Network Gateway(ExpressRoute) can be created through the Virtual Network Gateway, (Gateway type: ExpressRoute). The ExpressRouteGateway is created though the Virtual Wan -> Hubs, you can find the ExpressRoute Gateway after the hub is created.

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #26746

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[xuzhang3]

------- Stdout: -------
=== RUN   TestAccExpressRouteConnection
=== RUN   TestAccExpressRouteConnection/Resource
=== RUN   TestAccExpressRouteConnection/Resource/basic
=== RUN   TestAccExpressRouteConnection/Resource/requiresImport
=== RUN   TestAccExpressRouteConnection/Resource/complete
=== RUN   TestAccExpressRouteConnection/Resource/update
    testcase.go:128: Step 3/4 error: Error running apply: exit status 1
        Error: creating Route Map (Subscription: "*******"
        Resource Group Name: "acctestRG-erconnection-240806121225941266"
        Virtual Hub Name: "acctest-vhub-240806121225941266"
        Route Map Name: "routemapfirst"): polling after RouteMapsCreateOrUpdate: context deadline exceeded
          with azurerm_route_map.routemap1,
          on terraform_plugin_test.tf line 93, in resource "azurerm_route_map" "routemap1":
          93: resource "azurerm_route_map" "routemap1" {
        creating Route Map (Subscription: "*******"
        Resource Group Name: "acctestRG-erconnection-240806121225941266"
        Virtual Hub Name: "acctest-vhub-240806121225941266"
        Route Map Name: "routemapfirst"): polling after RouteMapsCreateOrUpdate:
        context deadline exceeded
--- FAIL: TestAccExpressRouteConnection (23037.43s)
    --- FAIL: TestAccExpressRouteConnection/Resource (23037.43s)
        --- PASS: TestAccExpressRouteConnection/Resource/basic (5392.82s)
        --- PASS: TestAccExpressRouteConnection/Resource/requiresImport (5275.42s)
        --- PASS: TestAccExpressRouteConnection/Resource/complete (5279.29s)
        --- FAIL: TestAccExpressRouteConnection/Resource/update (7089.90s)
FAIL

[xuzhang3]

=== RUN   TestAccExpressRouteConnection/Resource
=== RUN   TestAccExpressRouteConnection/Resource/update
--- PASS: TestAccExpressRouteConnection (7852.24s)
    --- PASS: TestAccExpressRouteConnection/Resource (7852.24s)
        --- PASS: TestAccExpressRouteConnection/Resource/update (7852.24s)

[xuzhang3]

All test passed, but some of the tests are relate to azurerm_route_map which may result in timeout. Increase the timeout of azurerm_route_map from 30 mins to 60 mins

[stephybun]

Thanks @xuzhang3. Could you fix the spelling of the variable please?

[stephybun]

Could we be mindful of the spelling here

Suggested change

	privateLinkFatPath := d.GetRawConfig().AsValueMap()["private_link_fast_path_enabled"]
	privateLinkFastPath := d.GetRawConfig().AsValueMap()["private_link_fast_path_enabled"]

[xuzhang3]

fixed

[stephybun]

Suggested change

	privateLinkFatPath := d.GetRawConfig().AsValueMap()["private_link_fast_path_enabled"]
	privateLinkFastPath := d.GetRawConfig().AsValueMap()["private_link_fast_path_enabled"]

[stephybun]

Thanks @xuzhang3 LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.