mssql - fix Long Term Retention not supported for SQL database with Free edition

[cdituri]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Fixes the deployment of SQL Database Free tier by skipping Long-Term and Short-Term Retention Policies, which are not supported on the Free tier.

Fixes #16231
Fixes half of #13387

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

I added a minimal acceptance test for the unique case of deploying mssql resource on the Free tier. The new acceptance test passes and its log output can be found below.

Note: After passing the new test I attempted to run all the acceptance tests for service mssql but quickly hit my rate-limit and blew out my subscription's quota 🙃 Apologies there isn't more test output available. Hoping a github action will trigger and exhaustively test once this PR is opened...

PS C:\Go\src\github.com\hashicorp\terraform-provider-azurerm> make acctests SERVICE='mssql' TESTARGS='-run=TestAccMsSqlDatabase_free' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/mssql -run=TestAccMsSqlDatabase_free -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMsSqlDatabase_free
=== PAUSE TestAccMsSqlDatabase_free
=== CONT  TestAccMsSqlDatabase_free
--- PASS: TestAccMsSqlDatabase_free (325.52s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mssql 325.707s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• mssql - support deployment of SQL Database Free sku/tier resources [mssql - fix Long Term Retention not supported for SQL database with Free edition #26894]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #16231
Fixes half of #13387

[cdituri]

@stephybun I addressed your #26894 (comment) and made the test configuration explicit. If there's anything else you'd like changed just let me know. Cheers.

[stephybun]

Tests look good, thanks for this @cdituri. LGTM 💯

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.