-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_arc_machine
#26647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neil-yechenwei, Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍
@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. |
@neil-yechenwei, thank you for your updates. LGTM~ |
@katbyte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🛋️
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
This is the PR to support Hybrid Compute Machine.
Given HC suggests to use arc_* for this PR, so I named it to azurerm_arc_machine.
API Spec: https://github.com/Azure/azure-rest-api-specs/blob/1ad29756bd141a47cac770140105a706d065ae1b/specification/hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2024-07-10/HybridCompute.json#L352
Overview doc: https://learn.microsoft.com/en-us/azure/azure-arc/system-center-virtual-machine-manager/overview
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_arc_machine
This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.