Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - Fix a nonsense validation error when upgrading from StorageV2 to Storage (forcenew) #26639

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jul 15, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Fix #26596

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_storage_account - Fix a nonsense validation error when upgrading from StorageV2 to Storage (forcenew) [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #26596

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…ading from `StorageV2` to `Storage` (forcenew)
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo, LGTM 👍

@manicminer
Copy link
Contributor

manicminer commented Jul 18, 2024

Tests look good, failures are 4.0 related

Screenshot 2024-07-18 at 18 53 04

@manicminer manicminer merged commit c480ba4 into hashicorp:main Jul 18, 2024
30 checks passed
@github-actions github-actions bot added this to the v3.113.0 milestone Jul 18, 2024
manicminer added a commit that referenced this pull request Jul 18, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jul 19, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.112.0&#34; to &#34;3.113.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.113.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.113.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20240715.1100358` of
`hashicorp/go-azure-sdk`
([#26638](hashicorp/terraform-provider-azurerm#26638
`storage` - updating to use `hashicorp/go-azure-sdk`
([#26218](https://github.com/hashicorp/terraform-provider-azurerm/issues/26218))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_storage_account` - fix a validation bug when
replacing a StorageV2 account with a StorageV1 account
([#26639](hashicorp/terraform-provider-azurerm#26639
`azurerm_storage_account` - resolve an issue refreshing blob or queue
properties after recreation
([#26218](hashicorp/terraform-provider-azurerm#26218
`azurerm_storage_account` - resolve an issue setting tags for an
existing storage account where a policy mandates them
([#26218](hashicorp/terraform-provider-azurerm#26218
`azurerm_storage_account` - fix a persistent diff with the
`customer_managed_key` block
([#26218](hashicorp/terraform-provider-azurerm#26218
`azurerm_storage_account` - resolve several consistency related issues
when crreating a new storage account
([#26218](https://github.com/hashicorp/terraform-provider-azurerm/issues/26218))&#xA;&#xA;DEPRECATIONS:&#xA;&#xA;*
`azurerm_eventhub_namespace` - deprecate the `zone_redundant` field in
v4.0
([#26611](hashicorp/terraform-provider-azurerm#26611
`azurerm_servicebus_namespace` - deprecate the `zone_redundant` field in
v4.0
([#26611](hashicorp/terraform-provider-azurerm#26611;
&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/331/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot downgrade Storage Account from v2 to v1 because of access_tier validation
2 participants