New Resource: `azurerm_restore_point_collection` #26518

mbfrahry · 2024-07-01T23:47:57Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds support for Restore Point Collections will allow us to support restore points in the future

--- PASS: TestAccRestorePointCollection_basic (253.58s)
--- PASS: TestAccRestorePointCollection_update (243.54s)

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Resource: azurerm_restore_point_collection [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

catriona-m

Thanks @mbfrahry - I spotted a couple of minor things that might need fixed up but otherwise this LGTM!

catriona-m · 2024-07-03T09:28:05Z

internal/services/compute/restore_point_collection_resource.go

+			}
+
+			parameters := restorepointcollections.RestorePointCollection{
+				Location: config.Location,


Suggested change

Location: config.Location,

Location: location.Normalize(config.Location),

should we normalize the location here?

catriona-m · 2024-07-03T09:31:17Z

internal/services/compute/restore_point_collection_resource_test.go

+}
+
+resource "azurerm_subnet" "test" {
+  name                 = "internal-%[1]d"


should we prefix this with acctest?

catriona-m · 2024-07-03T09:33:40Z

website/docs/r/restore_point_collection.html.markdown

+* `create` - (Defaults to 45 minutes) Used when creating the Restore Point Collection.
+* `update` - (Defaults to 45 minutes) Used when updating the Restore Point Collection.
+* `delete` - (Defaults to 45 minutes) Used when deleting the Restore Point Collection.
+* `read` - (Defaults to 5 minutes) Used when retrieving the Restore Point Collection.


Suggested change

* `create` - (Defaults to 45 minutes) Used when creating the Restore Point Collection.

* `update` - (Defaults to 45 minutes) Used when updating the Restore Point Collection.

* `delete` - (Defaults to 45 minutes) Used when deleting the Restore Point Collection.

* `read` - (Defaults to 5 minutes) Used when retrieving the Restore Point Collection.

* `create` - (Defaults to 30 minutes) Used when creating the Restore Point Collection.

* `update` - (Defaults to 30 minutes) Used when updating the Restore Point Collection.

* `delete` - (Defaults to 30 minutes) Used when deleting the Restore Point Collection.

* `read` - (Defaults to 5 minutes) Used when retrieving the Restore Point Collection.

catriona-m · 2024-07-03T09:36:27Z

internal/services/compute/restore_point_collection_resource.go

+
+			existing, err := client.Get(ctx, *id, restorepointcollections.DefaultGetOperationOptions())
+			if err != nil {
+				return fmt.Errorf("checking for presence of existing %s: %+v", id, err)


Suggested change

return fmt.Errorf("checking for presence of existing %s: %+v", id, err)

return fmt.Errorf("retrieving %s: %+v", id, err)

…raform-provider-azurerm into f-restore-point-collection

mbfrahry · 2024-07-03T21:44:58Z

Thanks @catriona-m, taken care of

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.110.0" to "3.111.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.111.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.111.0
FEATURES:

* **New Resource:** `azurerm_restore_point_collection` ([#26518](https://github.com/hashicorp/terraform-provider-azurerm/issues/26518))

ENHANCEMENTS:

* dependencies: updating to `v0.20240701.1082110` of `github.com/hashicorp/go-azure-sdk` ([#26502](hashicorp/terraform-provider-azurerm#26502 `azurerm_disk_encryption_set` - support for the `managed_hsm_key_id` property ([#26201](hashicorp/terraform-provider-azurerm#26201 `azurerm_firewall_policy` - remove Computed from the `sku` property and add a default of `Standard` in 4.0 ([#26499](hashicorp/terraform-provider-azurerm#26499 `azurerm_kubernetes_cluster` - support updating `default_node_pool.os_sku` between `Ubuntu` and `AzureLinux` ([#26262](hashicorp/terraform-provider-azurerm#26262 `azurerm_kubernetes_cluster_node_pool` - support updating `os_sku` between `Ubuntu` and `AzureLinux` ([#26139](hashicorp/terraform-provider-azurerm#26139 `azurerm_service_plan` - support for new the Flex Consumption plan ([#26351](https://github.com/hashicorp/terraform-provider-azurerm/issues/26351))

BUG FIXES:

* `azurerm_kubernetes_cluster` - prevent a panic ([#26478](hashicorp/terraform-provider-azurerm#26478 `azurerm_kubernetes_cluster` - prevent a diff in `upgrade_settings` when the API returns an empty object ([#26541](hashicorp/terraform-provider-azurerm#26541 `azurerm_kubernetes_cluster_node_pool` - prevent a diff in `upgrade_settings` when the API returns an empty object ([#26541](hashicorp/terraform-provider-azurerm#26541 `azurerm_virtual_network_gateway` - split create and update function to fix lifecycle - ignore ([#26451](hashicorp/terraform-provider-azurerm#26451 `azurerm_virtual_network_gateway_connection` - split create and update function to fix lifecycle - ignore ([#26431](https://github.com/hashicorp/terraform-provider-azurerm/issues/26431))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/306/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

github-actions · 2024-08-03T02:08:09Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New Resource: azurerm_restore_point_collection

4d9e461

github-actions bot added documentation dependencies size/XL labels Jul 1, 2024

Update restore_point_collection.html.markdown

60dab34

mbfrahry mentioned this pull request Jul 2, 2024

New Resource: azurerm_virtual_machine_restore_point #26526

Merged

14 tasks

catriona-m approved these changes Jul 3, 2024

View reviewed changes

mbfrahry added 2 commits July 3, 2024 14:14

Address review

84adc74

Merge branch 'f-restore-point-collection' of github.com:hashicorp/ter…

ac3ec10

…raform-provider-azurerm into f-restore-point-collection

github-actions bot added the waiting-response label Jul 3, 2024

lint

30e0043

github-actions bot removed the waiting-response label Jul 3, 2024

mbfrahry added this to the v3.111.0 milestone Jul 3, 2024

mbfrahry merged commit 6ad8472 into main Jul 3, 2024
33 checks passed

mbfrahry deleted the f-restore-point-collection branch July 3, 2024 21:46

mbfrahry added a commit that referenced this pull request Jul 3, 2024

Update CHANGELOG.md for #26518

f22d720

github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_restore_point_collection` #26518

New Resource: `azurerm_restore_point_collection` #26518

mbfrahry commented Jul 1, 2024

catriona-m left a comment

catriona-m Jul 3, 2024

catriona-m Jul 3, 2024

catriona-m Jul 3, 2024

catriona-m Jul 3, 2024

mbfrahry commented Jul 3, 2024

github-actions bot commented Aug 3, 2024

	Location: config.Location,
	Location: location.Normalize(config.Location),

	return fmt.Errorf("checking for presence of existing %s: %+v", id, err)
	return fmt.Errorf("retrieving %s: %+v", id, err)

New Resource: azurerm_restore_point_collection #26518

New Resource: azurerm_restore_point_collection #26518

Conversation

mbfrahry commented Jul 1, 2024

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

catriona-m left a comment

Choose a reason for hiding this comment

catriona-m Jul 3, 2024

Choose a reason for hiding this comment

catriona-m Jul 3, 2024

Choose a reason for hiding this comment

catriona-m Jul 3, 2024

Choose a reason for hiding this comment

catriona-m Jul 3, 2024

Choose a reason for hiding this comment

mbfrahry commented Jul 3, 2024

github-actions bot commented Aug 3, 2024

New Resource: `azurerm_restore_point_collection` #26518

New Resource: `azurerm_restore_point_collection` #26518