azurerm_new_relic_monitor - Support identity
#26115
Conversation
There was a problem hiding this comment.
Thanks @ms-zhenhua. It looks like there are some fundamental issues with the identity property for this resource that should be raised with the Service Team, could you please open a swagger issue regarding the comments I left in-line and then link those in the code?
| @@ -520,3 +532,34 @@ func flattenUserInfoModel(input *monitors.UserInfo) []UserInfoModel { | |||
|
|
|||
| return append(outputList, output) | |||
| } | |||
|
|
|||
| // Currently the API only supports `SystemAssigned` type. | |||
There was a problem hiding this comment.
If the Swagger spec specifies that System and User assigned should be supported but the API in reality only supported SystemAssigned then we should raise an issue on the Rest API specs repo.
There was a problem hiding this comment.
created a issue to track this problem: Azure/azure-rest-api-specs#29256
| if identityValue.Type != identity.TypeNone { | ||
| properties.Identity = identityValue | ||
| } |
There was a problem hiding this comment.
This isn't how the Type field in Identity is usually handled which would imply a bug, this should also be raised as an issue on the Rest API specs repo.
There was a problem hiding this comment.
created a issue to track this problem: Azure/azure-rest-api-specs#29257
There was a problem hiding this comment.
In the future: can we also update the API Definition to expose the Identity field correctly too? We've spent a considerable amount of time standardising the behaviours (and methods) for the Identity types, so we should lean on them where possible - as such I've opened hashicorp/pandora#4171 which'll allow this.
|
Hi @stephybun, thank you for your review. I have created the issues and added them to the comments. Please take another review. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Support
identityforazurerm_new_relic_monitorto enablemetrics flowlike data dogPR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_new_relic_monitor- SupportidentityThis is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.