Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azurerm_container_registry: added missing tags property #2607

Merged
merged 2 commits into from
Jan 6, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 6, 2019

  • fixed a few datasource file names to be consistent with the rest
  • fixes small typo in `` test

fixes:

Test ended in panic.

------- Stdout: -------
=== RUN   TestAccDataSourceAzureRMContainerRegistry_basic
=== PAUSE TestAccDataSourceAzureRMContainerRegistry_basic
=== CONT  TestAccDataSourceAzureRMContainerRegistry_basic

------- Stderr: -------
panic: Invalid address to set: []string{"tags"}

@katbyte katbyte added this to the 1.21.0 milestone Jan 6, 2019
@katbyte katbyte requested a review from a team January 6, 2019 02:03
@ghost ghost added the size/XS label Jan 6, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@katbyte
Copy link
Collaborator Author

katbyte commented Jan 6, 2019

tests:

==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccDataSourceAzureRMContainerRegistry_basic -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceAzureRMContainerRegistry_basic
=== PAUSE TestAccDataSourceAzureRMContainerRegistry_basic
=== CONT  TestAccDataSourceAzureRMContainerRegistry_basic
--- PASS: TestAccDataSourceAzureRMContainerRegistry_basic (96.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	98.143s

==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMVirtualMachineScaleSet_upgradeModeUpdate -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMVirtualMachineScaleSet_upgradeModeUpdate
=== PAUSE TestAccAzureRMVirtualMachineScaleSet_upgradeModeUpdate
=== CONT  TestAccAzureRMVirtualMachineScaleSet_upgradeModeUpdate
--- PASS: TestAccAzureRMVirtualMachineScaleSet_upgradeModeUpdate (588.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	589.889s

@katbyte katbyte merged commit ba0bb15 into master Jan 6, 2019
@katbyte katbyte deleted the schema-panic/container_reg branch January 6, 2019 02:20
katbyte added a commit that referenced this pull request Jan 6, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants