appservice: conditionally rewriting the value for virtual_network_subnet_id
#25885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bnet_id` This fixes #25832 by ensuring that the Subnet ID is recased meaning that it'll be in the correct format. From our side since we're validating the user input for this field, it's hard for us to write a test-case for this one since it'd be caught by the validation - but this is caused by user input for this field (provisioned through an ARM Template etc) providing this value without the prefix '/', which the API should be requiring (but isn't).
manicminer
approved these changes
May 8, 2024
1 task
|
Tests look good 👍 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This fixes #25832 by ensuring that the Subnet ID is recased meaning that it'll be in the correct format.
From our side since we're validating the user input for this field, it's hard for us to write a test-case for this one since it'd be caught by the validation - but this is caused by user input for this field (provisioned through an ARM Template etc) providing this value without the prefix '/', which the API should be requiring (but isn't).