Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for daemonset-eviction-for-occupied-nodes #25764

Closed
1 task done
nemobis opened this issue Apr 26, 2024 · 2 comments
Closed
1 task done

Support for daemonset-eviction-for-occupied-nodes #25764

nemobis opened this issue Apr 26, 2024 · 2 comments
Labels
blocked enhancement preview service/kubernetes-cluster upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR

Comments

@nemobis
Copy link

nemobis commented Apr 26, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

The cluster autoscaler in AKS is nearly useless by default for the default pool, which always contains kube-system pods and usually some daemonset pods.

Currently the provider supports skip-nodes-with-local-storage and skip-nodes-with-system-pods, but additionally it would be good to have support for more cluster-autoscaler-profile-settings

  • daemonset-eviction-for-empty-nodes: "Whether DaemonSet pods will be gracefully terminated from empty nodes."
  • daemonset-eviction-for-occupied-nodes: "Whether DaemonSet pods will be gracefully terminated from non-empty nodes."

Both are currently marked as "in preview".

New or Affected Resource(s)/Data Source(s)

azurerm_kubernetes_cluster (auto_scaler_profile)

Potential Terraform Configuration

No response

References

https://learn.microsoft.com/en-us/azure/aks/cluster-autoscaler?tabs=azure-cli#cluster-autoscaler-profile-settings
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster#skip_nodes_with_local_storage

@rcskosir rcskosir added service/kubernetes-cluster enhancement preview blocked upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Apr 26, 2024
@rcskosir
Copy link
Contributor

Thanks for taking the time to open this issue. It looks like the behavior you requested is in Preview by the underlying AKS API so I am going to close it for now, please read here about the AKS API change in 4.x. Once the feature has become generally available and is accessible in a Stable API version, we can reopen this request or you can create a new one.

@rcskosir rcskosir closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked enhancement preview service/kubernetes-cluster upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

No branches or pull requests

2 participants