Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_web_app + azurerm_linux_web_app_slot - Set site_config.always_on as configured by the user during an update #25753

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

Apokalypt
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds the forgotten property site_config.always_on when the linux app service (slot or not) is updated. Currently, this property is not set during an update, which means that this value will be set to "false" by the API.
It also aligns the behavior of different app services.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.

Testing

Sorry, but I couldn't run acceptance tests because I don't have enough permissions in my team to make them run properly. However, some tests were run manually and some checks/tests were run directly with the API to make sure everything worked despite my technical limitations.

Note

I've added a control to prevent regression, but since I'm only controlling one property, wouldn't it be better to remove it? (this control has been added in a complete update but all other properties are not checked)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_linux_web_app - Set site_config.always_on as configured by the user during an update
  • azurerm_linux_web_app_slot - Set site_config.always_on as configured by the user during an update

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #25115

@Apokalypt
Copy link
Contributor Author

Apokalypt commented Jul 2, 2024

UP 😄

@pacorreia

This comment was marked as off-topic.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Apokalypt - LGTM 👍

@jackofallops
Copy link
Member

Tests look fine:

image

@jackofallops jackofallops merged commit 9d19512 into hashicorp:main Jul 25, 2024
29 checks passed
@github-actions github-actions bot added this to the v3.114.0 milestone Jul 25, 2024
jackofallops added a commit that referenced this pull request Jul 25, 2024
@pacorreia
Copy link

Many thanks to all involved!

@Apokalypt Apokalypt deleted the fix/linux-update-always_on branch July 30, 2024 14:40
lonegunmanb pushed a commit to lonegunmanb/terraform-provider-azurerm that referenced this pull request Aug 5, 2024
…te_config.always_on`` as configured by the user during an update (hashicorp#25753)

* fix(linux_web_app_*): Set "AlwaysOn" property on update

* tests(linux_web_app_*): Validate "AlwaysOn" property on update
lonegunmanb pushed a commit to lonegunmanb/terraform-provider-azurerm that referenced this pull request Aug 5, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_linux_web_app - site_config.always_on cannot be updated after initial deployment
3 participants