-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new data source azurerm_network_manager_connectivity_configuration
#25746
new data source azurerm_network_manager_connectivity_configuration
#25746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @teowa - Just a couple things to take a look at below if you could.
Thanks!
internal/services/network/network_manager_connectivity_configuration_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/network/network_manager_connectivity_configuration_data_source.go
Outdated
Show resolved
Hide resolved
website/docs/d/network_manager_connectivity_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/network_manager_connectivity_configuration.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍵
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
new data source
azurerm_network_manager_connectivity_configuration
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_network_manager_connectivity_configuration
This is a (please select all that apply):
Related Issue(s)
Fixes #25587
Note
If this PR changes meaningfully during the course of review please update the title and description as required.