Add azurerm_application_insights_api_key resource

[pdecat]

Resolves #2547

TODO:

• add documentation
• add changelog

[pdecat]

Acceptance test results:

# make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1'                                                        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_requiresImport
--- SKIP: TestAccAzureRMApplicationInsightsAPIKey_requiresImport (0.00s)
    resource_arm_application_insights_api_key_test.go:33: Skipping since resources aren't required to be imported                                         
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_no_permission (58.52s)
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_full_permissions
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions (92.84s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission (138.72s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission (138.93s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_full_permissions (90.52s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       149.063s

[tombuildsstuff]

hey @pdecat

Thanks for this PR :)

I've taken a look through and left some comments inline about the design of the resources schema, but this is otherwise off to a good start 👍

Thanks!

[pdecat]

Updated acceptance test results:

# make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1'                                                        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_requiresImport
--- SKIP: TestAccAzureRMApplicationInsightsAPIKey_requiresImport (0.00s)
    resource_arm_application_insights_api_key_test.go:33: Skipping since resources aren't required to be imported                                         
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_full_permissions
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_no_permission (60.60s)
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission (73.83s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_full_permissions (73.89s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission (75.60s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions (73.05s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       133.687s

I'll proceed to documentation updates now that the end-user exposed schema should no longer change.

[katbyte]

@pdecat,

This is looking in good shape. I've let a couple comments inline and once they are addressed this should be good to merge 🙂

[pdecat]

Current acceptance test results:

# make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_requiresImport
--- SKIP: TestAccAzureRMApplicationInsightsAPIKey_requiresImport (0.00s)
    resource_arm_application_insights_api_key_test.go:33: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_no_permission (61.67s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission (74.94s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_full_permissions (74.99s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions (75.10s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission (77.97s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       78.001s

[katbyte]

Thank you for the updates @pdecat, LGTM now 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!