Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_virtual_machine_automanage_configuration_assignment #25480

Merged
merged 5 commits into from
May 6, 2024

Conversation

liuwuliuyun
Copy link
Contributor

@liuwuliuyun liuwuliuyun commented Apr 2, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

  • New Resource: azurerm_virtual_machine_automanage_configuration_assignment
  • Adding test cases for this resource
  • Adding documentation for using this resource

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.3\tmp\GoLand\___TestAccVirtualMachineConfigurationAssignment_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_automanage.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/automanage #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.3\tmp\GoLand\___TestAccVirtualMachineConfigurationAssignment_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_automanage.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccVirtualMachineConfigurationAssignment_basic\E$ #gosetup
=== RUN   TestAccVirtualMachineConfigurationAssignment_basic
=== PAUSE TestAccVirtualMachineConfigurationAssignment_basic
=== CONT  TestAccVirtualMachineConfigurationAssignment_basic
--- PASS: TestAccVirtualMachineConfigurationAssignment_basic (338.49s)
PASS


Process finished with the exit code 0

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.3\tmp\GoLand\___TestAccVirtualMachineConfigurationAssignment_requireImport_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_automanage.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/automanage #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.3\tmp\GoLand\___TestAccVirtualMachineConfigurationAssignment_requireImport_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_automanage.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccVirtualMachineConfigurationAssignment_requireImport\E$ #gosetup
=== RUN   TestAccVirtualMachineConfigurationAssignment_requireImport
=== PAUSE TestAccVirtualMachineConfigurationAssignment_requireImport
=== CONT  TestAccVirtualMachineConfigurationAssignment_requireImport
--- PASS: TestAccVirtualMachineConfigurationAssignment_requireImport (350.29s)
PASS


Process finished with the exit code 0

For state migrations please test the changes locally and provide details here, such as the versions involved in testing the migration path. For further details on testing state migration changes please see our guide on state migrations in the contributor documentation. -->

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

@liuwuliuyun liuwuliuyun marked this pull request as ready for review April 2, 2024 09:37
@rcskosir
Copy link
Contributor

rcskosir commented Apr 2, 2024

@liuwuliuyun 👋 Thank you for using our new PR template! Can you please add a description under the description heading for what this PR does? This helps with the review process as well as traceability for our users. Thanks!

@liuwuliuyun
Copy link
Contributor Author

Mark as draft for internal review first

@liuwuliuyun liuwuliuyun closed this Apr 3, 2024
@liuwuliuyun liuwuliuyun reopened this Apr 3, 2024
@liuwuliuyun liuwuliuyun marked this pull request as draft April 3, 2024 02:22
@WodansSon WodansSon marked this pull request as ready for review April 10, 2024 05:15
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎲

@katbyte katbyte merged commit 27140fc into hashicorp:main May 6, 2024
35 checks passed
katbyte added a commit that referenced this pull request May 6, 2024
@github-actions github-actions bot added this to the v3.103.0 milestone May 6, 2024
Copy link

github-actions bot commented Jun 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
@liuwuliuyun liuwuliuyun deleted the automanage-vm-assignment branch September 19, 2024 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants