-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_linux_function_app_slot
: create content settings for linux function app slot too
#25412
azurerm_linux_function_app_slot
: create content settings for linux function app slot too
#25412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @stuartjbrown.
Looking at the linked issue I have some questions/suggestions around the usage. Would you mind checking out the comment I left and providing some feedback on it?
This PR is being labeled as "stale" because it has not been updated for 30 or more days. If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone. If you need some help completing this PR, please leave a comment letting us know. Thank you! |
Hi @stephybun - thanks for the update. I checked the comments on the issue - we are also doing the slot swap outside of Terraform in an Azure Pipeline. A TF slot swap wouldn't be practical for us as it could have unintended side effects so this fix would still be ideal. |
Hi @stephybun, can this be reviewed and merged, please? In my comment on the issue, Linux function slots are the outlier for how content share is set. Linux function app, Windows function app and Windows slot all have a common behaviour of setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the long wait on this @stuartjbrown.
The initial issue description and discussion within the team on this led us to believe that there was a deeper behavioural problem here that would require a more involved investigation.
Having finally come back to this and upon re-reading the comments, I see the discrepancy in the check across the four resources. Thanks for doing the digging there @tj-spyro.
LGTM 💯
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
When using the
azurerm_linux_function_app_slot
resource, the app settings / environment variablesWEBSITE_CONTENTSHARE
andWEBSITE_CONTENTAZUREFILECONNECTIONSTRING
are not created, as they are for the corresponding windows function app slot resource. This appears to break slot swapping between the main and the deployment slot.The Microsoft documentation is not clear on this but adding these settings manually appears to fix this issue.
fixes: #24901
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_linux_function_app_slot
- setWEBSITE_CONTENTSHARE
andWEBSITE_CONTENTAZUREFILECONNECTIONSTRING
settings if not provided [azurerm_linux_function_app_slotWEBSITE_CONTENTSHARE
andWEBSITE_CONTENTAZUREFILECONNECTIONSTRING
are not created or maintained across applies correctly, causing slot swapping to eventually fail #24901]This is a (please select all that apply):
Related Issue(s)
Fixes #24901
Note
If this PR changes meaningfully during the course of review please update the title and description as required.