-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netapp_account_resource
add missing Active Directory properties
#25340
Conversation
netapp_account_resource
add missing ad properties
netapp_account_resource
add missing ad propertiesnetapp_account_resource
add missing Active Directory properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bruceharrison1984 - couple comments left inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bruceharrison1984 - couple comments left inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🧲
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Description
This PR adds some properties to
netapp_account_resource
that were missing from the Active Directory configuration block. This is the first half of a PR that will enable Kerberos NetApp Volumes.ad_name
: This property is required to enable Kerberos functionalitykdc_ip
: This property is required to enable Kerberos functionalitysite_name
: This property is required in the Azure Portal, but was absent from the providerDefault-First-Site-Name
if left blank, which is what the Azure API was doing behind the scenes already.enable_aes_encryption
allow_local_nfs_users_with_ldap
server_root_ca_certificate
enable_ldap_over_tls
enable_ldap_signing
Our customer only needed support for Kerberos, but we added a couple more easy wins while we were here. There are still additional properties missing, but this PR adds the easiest ones.
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
netapp_account_resource
- support for thead_name
propertynetapp_account_resource
- support for thekdc_ip
propertynetapp_account_resource
- support for thesite_name
property [Support for Azure Netapp Files - AD Site Name #12462]netapp_account_resource
- support for theenable_aes_encryption
propertynetapp_account_resource
- support for theallow_local_nfs_users_with_ldap
propertynetapp_account_resource
- support for theserver_root_ca_certificate
propertynetapp_account_resource
- support for theenable_ldap_over_tls
propertynetapp_account_resource
- support for theenable_ldap_signing
propertynetapp_account_resource
- relaxsmb_server_name
regex [azurerm_netapp_account SMB server name check is too restrictive #11674]This is a (please select all that apply):
Related Issue(s)