azurerm_storage_blob Data Source - Fix a bug that incorrectly parse a storage account resource id instead of blob endpoint

[magodo]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

New Feature Submissions

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why below)

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Documentation Changes

• Documentation is written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.

Description

Fix a bug that incorrectly parse a storage account resource id instead of blob endpoint. Otherwise, it failed with:

        Error: parsing Account ID: expected the account "" to use a domain suffix of "core.windows.net"
          with data.azurerm_storage_blob.test,
          on terraform_plugin_test.tf line 60, in data "azurerm_storage_blob" "test":
          60: data "azurerm_storage_blob" "test" {

Testing Logs/Evidence

Related Issue(s)

This PR fixes several failing test cases on TeamCity: https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_STORAGE/118781?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildDeploymentsSection=false&expandBuildChangesSection=true&expandBuildTestsSection=true

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_storage_blob Data Source - Fix a bug that incorrectly parse a storage account resource id instead of blob endpoint [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[BHoggs]

Hi, this bug appears to also exist in the table storage data source, as per #25267 . Possible to fix both in this PR? They look to be related.

[manicminer]

Thanks for this fix @magodo, this LGTM 👍

[manicminer]

@BHoggs I'll open a PR to fix the data.azurerm_storage_table_entity bug shortly (it's the same logic error)

Edit: see #25307

[manicminer]

Test results

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.