-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_container_app_custom_domain
- fix when azurerm_container_app
has secret
specified (#25196)
#25251
azurerm_container_app_custom_domain
- fix when azurerm_container_app
has secret
specified (#25196)
#25251
Conversation
azurerm_container_app_custom_domain
- fix when azurerm_container_app
has secret
specified (#25196)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AButler, apologies for the premature approval. Looks like this will need some fixes to get around linting
@mbfrahry Sorry about that - was missing some imports. Have pushed the changes. |
@mbfrahry I'm unsure why this one check is failing as it appears to be unrelated to the changes I made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AButler - LGTM 🚒
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Documentation Changes
Description
Secrets were not being resolved when updating the container app.
Testing Logs/Evidence
Related Issue(s)
Fixes #25196.
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_container_app_custom_domain
- fix when container app has secrets [azurerm_container_app_custom_domain errors if container app has private registry (secret set) #25196]This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.