azurerm_cosmosdb_postgresql_cluster: add server names information t…

[reastyn]

I have tried to deploy CosmosDB Postgres, but with some of the updates they added a random hexadecimal string to coordinator domain (from c-acctestcluster240313222245905652.postgres.cosmos.azure.com -> c-acctestcluster240313222245905652.efyg2q5iqomwly.postgres.cosmos.azure.com). When I wanted to use this domain to be passed to other modules I couldn't as I can derive the domain from the service name. Therefore I just propagated the server_names property to the attributes, which means it can be used as for example a output.

Testing Logs/Evidence

I added the attribute to the basic test as seen in internal/services/cosmos/cosmosdb_postgresql_cluster_resource_test.go and successfully ran test locally.

Change Log

• azurerm_cosmosdb_postgresql_cluster - add fully qualified domain name to attributes

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

[reastyn]

I also just noticed, that this stackoverflow mentions this problem
https://stackoverflow.com/questions/76579820/output-azure-cosmos-db-for-postgresql-connection-string-with-terraform

[stephybun]

Thanks @reastyn. I left some comments around consistency, would you mind taking a look at those? Once they're addressed we can take another look through.

[stephybun]

Minor but for consistency could we rename this to

Suggested change

	func formatServerNames(input *[]clusters.ServerNameItem) []ServerNameItem {
	func flattenServerNames(input *[]clusters.ServerNameItem) []ServerNameItem {

[stephybun]

We should be setting an empty value into state instead of nil here

Suggested change

	if input == nil {
	return nil
	}
	var output []ServerNameItem
	var output []ServerNameItem
	if input == nil {
	return output
	}

[stephybun]

We can shorten this to servers, _names is implicit and one of the attributes in the block is already called name

Suggested change

	"server_names": {
	"servers": {

[stephybun]

Since this is a block it should be

Suggested change

	* `server_names` - The name of the servers and its fully qualified domain name
	* `servers` - A `servers` block as defined below.
	---
	A `servers` block exports the following:
	* `fqdn` - The Fully Qualified Domain Name of the server.
	* `name` - The name of the server.

[reastyn]

Thanks a lot for taking a look, the issues you mentioned should be resolved

[stephybun]

Thanks @reastyn LGTM 👍

[NemSimpraga]

Thank you @reastyn ! I am currently doing a hack/patch to get this very very basic property via azapi , which I do NOT like! I mean it baffles me how this resource could've even been created without that attribute out of all! Deploying a DB and not being able to query it's endpoint? Crazy!

data "azapi_resource" "db" {
  name                   = azurerm_cosmosdb_postgresql_cluster.db.name
  parent_id              = azurerm_resource_group.main.id
  type                   = "Microsoft.DBforPostgreSQL/serverGroupsv2@2023-03-02-preview"
  response_export_values = ["properties.serverNames"]
}

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.