azurerm_container_registry - Avoid unnecessary recreate when georeplication.tags update

[magodo]

This PR fixes two things:

• The first commit fixes some problematic code introduced in Address TODO items in preparation for 3.0 beta (3/many) #15340, where those code only handles v2.0 correctly, but are meaningless for v3.0
• The second commit fixes azurerm_container_registry georeplications will be recreated when resource tags are updated #24960, where the georeplication's zone redundency enabled flag is checked by pointer, instead of value,to tell whether a recreate of those georeplications are needed.

[catriona-m]

Hi @magodo

It looks like this has some test failures, but once those are addressed we can take another look at this. Thanks!

------- Stdout: -------
=== RUN   TestAccContainerRegistry_geoReplication
=== PAUSE TestAccContainerRegistry_geoReplication
=== CONT  TestAccContainerRegistry_geoReplication
    testcase.go:113: Step 5/10 error: After applying this test step, the plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # azurerm_container_registry.test will be updated in-place
          ~ resource "azurerm_container_registry" "test" {
                id                            = "/subscriptions/*******/resourceGroups/acctestRG-acr-240223113953509225/providers/Microsoft.ContainerRegistry/registries/testacccr240223113953509225"
                name                          = "testacccr240223113953509225"
                tags                          = {}
                # (16 unchanged attributes hidden)
              ~ georeplications {
                  ~ location                  = "eastus2" -> "westeurope"
                    tags                      = {}
                    # (2 unchanged attributes hidden)
                }
              ~ georeplications {
                  ~ location                  = "westeurope" -> "eastus2"
                  + tags                      = {}
                    # (2 unchanged attributes hidden)
                }
            }
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccContainerRegistry_geoReplication (484.36s)
FAIL

[magodo]

Hi @catriona-m, this is not an issue introduced by this PR, as if you switch the order of the ARM_TEST_LOCATION_ALT and ARM_TEST_LOCATION_ALT2, it shall pass.

You can find the details here: #17987 (comment).

[catriona-m]

Hi @catriona-m, this is not an issue introduced by this PR, as if you switch the order of the ARM_TEST_LOCATION_ALT and ARM_TEST_LOCATION_ALT2, it shall pass.

You can find the details here: #17987 (comment).

Thanks for explaining @magodo. Would it make sense to fix those tests as part of this PR?

[magodo]

@catriona-m Sure, I've updated the test and verified that both order of the locations pass the test locally.

[stephybun]

Thanks @magodo. Unfortunately the test is still failing with the same error on Team City. Is there an explanation for that?

[magodo]

@stephybun I have no idea... I tried to run it locally and on teamcity, with the same setting as the failing test case, all passed:

[stephybun]

How odd, thanks for double checking. Thanks @magodo LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.