r/kubernetes_cluster: support for rbac without azuread / exporting the admin profile #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resource Tests pass for this (excluding the version of K8s used in the test being unavailable, which I've pushed a commit to fix:
Data Source tests pass, excluding a known test failure which we'll look at separately:
|
ams0
reviewed
Dec 19, 2018
| @@ -169,6 +169,8 @@ A `role_based_access_control` block supports the following: | |||
|
|
|||
| * `azure_active_directory` - (Required) An `azure_active_directory` block. Changing this forces a new resource to be created. | |||
There was a problem hiding this comment.
is this still required? Or can be skipped if one wants just RBAC?
There was a problem hiding this comment.
good spot - this is now optional
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Role Based Access Control without Azure Active Directory to both the
azurerm_kubernetes_clusterResource and Data Source; and also exports the Kubernetes Admin Profile if Role Based Access Control with AzureAD is enabled on the cluster to both the Resource & Data Source too.Fixes #2345
Fixes #2421
Supersedes #2347