-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for authenticating using Service Principal with a Client Certificate #2471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I did leave a few comments and suggestion in the PR... they are all very minor and should not block the merging of this PR.
website/docs/auth/service_principal_client_certificate.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/auth/service_principal_client_secret.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments inline @tombuildsstuff, but overall LGTM 👍
website/docs/auth/service_principal_client_secret.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/auth/service_principal_client_secret.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/auth/service_principal_client_secret.html.markdown
Outdated
Show resolved
Hide resolved
Co-Authored-By: tombuildsstuff <[email protected]>
…erraform-provider-azurerm into f/auth/client-cert
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR introduces support for authenticating as a Service Principal using a Client Certificate. To be able to better accommodate this I've split the authentication related pages out into their own directory; and also rewritten most of the Azure Provider page to include some more useful information
Fixes #1573