Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for authenticating using Service Principal with a Client Certificate #2471

Merged
merged 12 commits into from
Dec 11, 2018

Conversation

tombuildsstuff
Copy link
Contributor

This PR introduces support for authenticating as a Service Principal using a Client Certificate. To be able to better accommodate this I've split the authentication related pages out into their own directory; and also rewritten most of the Azure Provider page to include some more useful information

Fixes #1573

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I did leave a few comments and suggestion in the PR... they are all very minor and should not block the merging of this PR.

README.md Outdated Show resolved Hide resolved
website/docs/auth/managed_service_identity.html.markdown Outdated Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments inline @tombuildsstuff, but overall LGTM 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff merged commit d56d58c into master Dec 11, 2018
@tombuildsstuff tombuildsstuff deleted the f/auth/client-cert branch December 11, 2018 09:43
tombuildsstuff added a commit that referenced this pull request Dec 11, 2018
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants