Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: MariaDB Database #2445

Merged
merged 33 commits into from
Dec 6, 2018
Merged

New Resource: MariaDB Database #2445

merged 33 commits into from
Dec 6, 2018

Conversation

WodansSon
Copy link
Collaborator

fixes #2432

@WodansSon WodansSon requested a review from katbyte December 5, 2018 01:06
@WodansSon WodansSon added this to the 1.20.0 milestone Dec 5, 2018
@WodansSon
Copy link
Collaborator Author

image

katbyte
katbyte requested changes Dec 5, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jeffreyCline,

Thank you for this contribution, it's off to a good start and i've left a few mostly minor comments inline, once these are addressed we can get this merged

azurerm/resource_arm_mariadb_database.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mariadb_database.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mariadb_database.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mariadb_database.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mariadb_database.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mariadb_database.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mariadb_database.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mariadb_database_test.go Outdated Show resolved Hide resolved
tombuildsstuff
tombuildsstuff reviewed Dec 5, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jeffreyCline

I've left a couple of other minor comments in addition to @katbyte's - but this otherwise LGTM 👍

azurerm/resource_arm_mariadb_database.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mariadb_database.go Outdated Show resolved Hide resolved
@WodansSon
Copy link
Collaborator Author

image

@WodansSon
Copy link
Collaborator Author

image

katbyte
katbyte approved these changes Dec 6, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghost ghost added size/XXL and removed size/XL labels Dec 6, 2018
@katbyte katbyte force-pushed the nr-mariadb-database branch from 08927cd to a2671f7 Compare December 6, 2018 19:31
@ghost ghost added size/XL and removed size/XXL labels Dec 6, 2018
@katbyte katbyte force-pushed the nr-mariadb-database branch from a592d69 to a2671f7 Compare December 6, 2018 19:39
@WodansSon WodansSon merged commit 5583b0e into master Dec 6, 2018
@WodansSon WodansSon deleted the nr-mariadb-database branch December 6, 2018 20:44
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/mariadb size/XL
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

New resource request: Azure Database for MariaDB
3 participants
@WodansSon @tombuildsstuff @katbyte