Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_iothub - fix a bug for local_auth_enabled #24326

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Dec 25, 2023

GET on the resource might be returned with 404 just after an update. tracked on Azure/azure-rest-api-specs#27183

which might cause the following error:

 Error: Provider produced inconsistent result after apply
        When applying changes to azurerm_iothub.test, provider
        "provider[\"registry.terraform.io/hashicorp/azurerm\"]" produced an
        unexpected new value: Root resource was present, but now absent.
        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

test

❯ tftest iothub TestAccIotHub_                   
=== RUN   TestAccIotHub_basic
=== PAUSE TestAccIotHub_basic
=== RUN   TestAccIotHub_networkRulesSet
=== PAUSE TestAccIotHub_networkRulesSet
=== RUN   TestAccIotHub_requiresImport
=== PAUSE TestAccIotHub_requiresImport
=== RUN   TestAccIotHub_standard
=== PAUSE TestAccIotHub_standard
=== RUN   TestAccIotHub_customRoutes
=== PAUSE TestAccIotHub_customRoutes
=== RUN   TestAccIotHub_enrichments
=== PAUSE TestAccIotHub_enrichments
=== RUN   TestAccIotHub_removeEndpointsAndRoutes
=== PAUSE TestAccIotHub_removeEndpointsAndRoutes
=== RUN   TestAccIotHub_fileUpload
=== PAUSE TestAccIotHub_fileUpload
=== RUN   TestAccIotHub_fileUploadAuthenticationTypeUserAssignedIdentity
=== PAUSE TestAccIotHub_fileUploadAuthenticationTypeUserAssignedIdentity
=== RUN   TestAccIotHub_fileUploadAuthenticationTypeUpdate
=== PAUSE TestAccIotHub_fileUploadAuthenticationTypeUpdate
=== RUN   TestAccIotHub_withDifferentEndpointResourceGroup
=== PAUSE TestAccIotHub_withDifferentEndpointResourceGroup
=== RUN   TestAccIotHub_fallbackRoute
=== PAUSE TestAccIotHub_fallbackRoute
=== RUN   TestAccIotHub_publicAccess
=== PAUSE TestAccIotHub_publicAccess
=== RUN   TestAccIotHub_minTLSVersion
=== PAUSE TestAccIotHub_minTLSVersion
=== RUN   TestAccIotHub_LocalAuth
=== PAUSE TestAccIotHub_LocalAuth
=== RUN   TestAccIotHub_cloudToDevice
=== PAUSE TestAccIotHub_cloudToDevice
=== RUN   TestAccIotHub_identitySystemAssigned
=== PAUSE TestAccIotHub_identitySystemAssigned
=== RUN   TestAccIotHub_identitySystemAssignedUserAssigned
=== PAUSE TestAccIotHub_identitySystemAssignedUserAssigned
=== RUN   TestAccIotHub_identityUserAssigned
=== PAUSE TestAccIotHub_identityUserAssigned
=== RUN   TestAccIotHub_identityUpdate
=== PAUSE TestAccIotHub_identityUpdate
=== RUN   TestAccIotHub_endpointAuthenticationTypeUserAssignedIdentity
=== PAUSE TestAccIotHub_endpointAuthenticationTypeUserAssignedIdentity
=== RUN   TestAccIotHub_endpointAuthenticationTypeUpdate
=== PAUSE TestAccIotHub_endpointAuthenticationTypeUpdate
=== CONT  TestAccIotHub_basic
=== CONT  TestAccIotHub_fallbackRoute
=== CONT  TestAccIotHub_identitySystemAssignedUserAssigned
=== CONT  TestAccIotHub_endpointAuthenticationTypeUpdate
=== CONT  TestAccIotHub_endpointAuthenticationTypeUserAssignedIdentity
=== CONT  TestAccIotHub_identityUpdate
=== CONT  TestAccIotHub_identityUserAssigned
=== CONT  TestAccIotHub_LocalAuth
--- PASS: TestAccIotHub_identitySystemAssignedUserAssigned (366.54s)
=== CONT  TestAccIotHub_identitySystemAssigned
--- PASS: TestAccIotHub_basic (383.15s)
=== CONT  TestAccIotHub_cloudToDevice
--- PASS: TestAccIotHub_fallbackRoute (384.18s)
=== CONT  TestAccIotHub_minTLSVersion
--- PASS: TestAccIotHub_identityUserAssigned (524.71s)
=== CONT  TestAccIotHub_removeEndpointsAndRoutes
--- PASS: TestAccIotHub_LocalAuth (640.15s)
=== CONT  TestAccIotHub_withDifferentEndpointResourceGroup
--- PASS: TestAccIotHub_identitySystemAssigned (385.52s)
=== CONT  TestAccIotHub_fileUploadAuthenticationTypeUpdate
--- PASS: TestAccIotHub_endpointAuthenticationTypeUserAssignedIdentity (779.22s)
=== CONT  TestAccIotHub_fileUploadAuthenticationTypeUserAssignedIdentity
--- PASS: TestAccIotHub_minTLSVersion (410.00s)
=== CONT  TestAccIotHub_fileUpload
--- PASS: TestAccIotHub_cloudToDevice (493.98s)
=== CONT  TestAccIotHub_publicAccess
--- PASS: TestAccIotHub_identityUpdate (902.01s)
=== CONT  TestAccIotHub_standard
--- PASS: TestAccIotHub_withDifferentEndpointResourceGroup (502.72s)
=== CONT  TestAccIotHub_enrichments
--- PASS: TestAccIotHub_removeEndpointsAndRoutes (688.02s)
=== CONT  TestAccIotHub_customRoutes
--- PASS: TestAccIotHub_fileUploadAuthenticationTypeUserAssignedIdentity (469.46s)
=== CONT  TestAccIotHub_requiresImport
--- PASS: TestAccIotHub_endpointAuthenticationTypeUpdate (1267.08s)
=== CONT  TestAccIotHub_networkRulesSet
--- PASS: TestAccIotHub_standard (378.09s)
--- PASS: TestAccIotHub_fileUpload (543.96s)
--- PASS: TestAccIotHub_publicAccess (622.98s)
--- PASS: TestAccIotHub_requiresImport (373.54s)
--- PASS: TestAccIotHub_fileUploadAuthenticationTypeUpdate (901.71s)
--- PASS: TestAccIotHub_enrichments (523.31s)
--- PASS: TestAccIotHub_customRoutes (549.55s)
--- PASS: TestAccIotHub_networkRulesSet (505.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/iothub	1773.128s

@ziyeqf ziyeqf marked this pull request as ready for review December 25, 2023 08:34
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌧️

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌧️

@katbyte katbyte merged commit 1f059ba into hashicorp:main Jan 4, 2024
30 checks passed
@github-actions github-actions bot added this to the v3.86.0 milestone Jan 4, 2024
katbyte added a commit that referenced this pull request Jan 4, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jan 6, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.85.0&#34; to
&#34;3.86.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.86.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.86.0&#xA;FEATURES:&#xA;&#xA;*
New Data Source: `azurerm_dashboard_grafana`
([#24243](hashicorp/terraform-provider-azurerm#24243
New Resource: `azurerm_log_analytics_workspace_table`
([#24229](hashicorp/terraform-provider-azurerm#24229
New Resource: `azurerm_automation_powershell72_module`
([#23980](hashicorp/terraform-provider-azurerm#23980
New Resource: `azurerm_data_factory_credential_user_managed_identity`
([#24307](https://github.com/hashicorp/terraform-provider-azurerm/issues/24307))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20231215.1114251` of
`hashicorp/go-azure-sdk`
([#24251](hashicorp/terraform-provider-azurerm#24251
dependencies: `azurerm_spring_cloud_api_portal` - update to use
`hashicorp/go-azure-sdk`
([#24321](hashicorp/terraform-provider-azurerm#24321
Data Source: `azurerm_kusto_cluster` - now exports the `identity` block
([#24314](hashicorp/terraform-provider-azurerm#24314
`azurerm_data_protection_backup_policy_postgresql` - support for the
`time_zone` property
([#24312](hashicorp/terraform-provider-azurerm#24312
`azurerm_data_protection_backup_policy_disk` - support for the
`time_zone` property
([#24312](hashicorp/terraform-provider-azurerm#24312
`azurerm_key_vault_managed_hardware_security_module` -the `tags`
property can now be updated
([#24333](hashicorp/terraform-provider-azurerm#24333
`azurerm_logic_app_standard` - support for the
`site_config.0.public_network_access_enabled` property
([#24257](hashicorp/terraform-provider-azurerm#24257
`azurerm_log_analytics_workspace_table` - support for the `plan`
property
([#24341](hashicorp/terraform-provider-azurerm#24341
`azurerm_linux_web_app` - support the value `20-lts` for the
`node_version` property
([#24289](hashicorp/terraform-provider-azurerm#24289
`azurerm_recovery_services_vault` - support creation with immutability
set to locked
([#23806](hashicorp/terraform-provider-azurerm#23806
`azurerm_spring_cloud_service` - support for the `sku_tier` property
([#24103](https://github.com/hashicorp/terraform-provider-azurerm/issues/24103))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* Data Source: `azurerm_role_definition` - correctly
export the `role_definition_id` attribute
([#24320](hashicorp/terraform-provider-azurerm#24320
`azurerm_bot_service` - fixing a bug where
`public_network_access_enabled` was always set to `true`
([#24255](hashicorp/terraform-provider-azurerm#24255
`azurerm_bot_service_azure_bot` - `tags` can now be updated
([#24332](hashicorp/terraform-provider-azurerm#24332
`azurerm_cosmosdb_account` - fix validation for the `ip_range_filter`
property
([#24306](hashicorp/terraform-provider-azurerm#24306
`azurerm_linux_virtual_machine` - the
`additional_capabilities.0.ultra_ssd_enabled` can now be changed during
the update
([#24274](hashicorp/terraform-provider-azurerm#24274
`azurerm_logic_app_standard` - update the default value of `version`
from `~3` which is no longer supported to `~4`
([#24134](hashicorp/terraform-provider-azurerm#24134
`azurerm_logic_app_standard` - fix a crash when setting the default
`version` 4.0 flag
([#24322](hashicorp/terraform-provider-azurerm#24322
`azurerm_iothub_device_update_account` - changing the `sku` property now
creates a new resource
([#24324](hashicorp/terraform-provider-azurerm#24324
`azurerm_iothub` - prevent an inconsistant value after an apply
([#24326](hashicorp/terraform-provider-azurerm#24326
`azurerm_orchestrated_virtual_machine_scale_set` - correctly update the
resource when hotpatch is enabled
([#24335](hashicorp/terraform-provider-azurerm#24335
`azurerm_windows_virtual_machine` - the
`additional_capabilities.0.ultra_ssd_enabled` can now be changed during
the update
([#24274](hashicorp/terraform-provider-azurerm#24274
`azurerm_scheduled_query_rules_alert` - changing the `data_source_id`
now creates a new resource
([#24327](hashicorp/terraform-provider-azurerm#24327
`azurerm_scheduled_query_rules_log` - changing the `data_source_id` now
creates a new resource
([#24327](https://github.com/hashicorp/terraform-provider-azurerm/issues/24327))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/985/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Copy link

github-actions bot commented May 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants