New Resource: `azurerm_system_center_virtual_machine_manager_server` #24278

neil-yechenwei · 2023-12-19T07:53:59Z

--- PASS: TestAccSystemCenterVirtualMachineManagerServerSequential/scvmmServer/basic (231.24s)
--- PASS: TestAccSystemCenterVirtualMachineManagerServerSequential/scvmmServer/requiresImport (239.39s)
--- PASS: TestAccSystemCenterVirtualMachineManagerServerSequential/scvmmServer/complete (220.69s)
--- PASS: TestAccSystemCenterVirtualMachineManagerServerSequential/scvmmServer/update (296.47s)

References:
Azure doc
REST API specs

…machinemanagermanagementserver

ms-zhenhua

Hey @neil-yechenwei

Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

internal/services/systemcentervirtualmachinemanager/resourceids.go

...s/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_server_resource.go

...temcentervirtualmachinemanager/system_center_virtual_machine_manager_server_resource_test.go

website/docs/r/system_center_virtual_machine_manager_server.html.markdown

neil-yechenwei · 2023-12-21T08:36:59Z

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. Thanks.

...s/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_server_resource.go

website/docs/r/system_center_virtual_machine_manager_server.html.markdown

…machinemanagermanagementserver

website/docs/r/system_center_virtual_machine_manager_server.html.markdown

katbyte

LGTM 🖥️

katbyte · 2024-01-04T03:59:06Z

...temcentervirtualmachinemanager/system_center_virtual_machine_manager_server_resource_test.go

+	if os.Getenv("ARM_TEST_CUSTOM_LOCATION_ID") == "" || os.Getenv("ARM_TEST_FQDN") == "" || os.Getenv("ARM_TEST_PORT") == "" || os.Getenv("ARM_TEST_USERNAME") == "" || os.Getenv("ARM_TEST_PASSWORD") == "" {
+		t.Skip("Skipping as one of `ARM_TEST_CUSTOM_LOCATION_ID`, `ARM_TEST_FQDN`, `ARM_TEST_PORT`, `ARM_TEST_USERNAME`, `ARM_TEST_PASSWORD` was not specified")


actually, how come these need to be ENV variables and are not part of the config?

@katbyte , Because creating System Center Virtual Machine Manager Server requires the dependent resources (like SCVMM host machine/Arc Resource Bridge/Custom Location/etc) with additional configurations.

Is there any way we could spin these up via terraform so we can actually test this resource in teamcity?

@katbyte , Creating this resource requires SCVMM host machine that is hosted in the LAB infra (and not as Azure VM). So I assume that we always need to pass the test parameters from outside while running test case.

…ashicorp#24278) * New Resource: azurerm_system_center_virtual_machine_manager_server * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.92.0" to "3.93.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.93.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.93.0
* **New Data Source**: `azurerm_express_route_circuit_peering` ([#24971](hashicorp/terraform-provider-azurerm#24971 **New Data Source**: `azurerm_storage_table_entities` ([#24973](hashicorp/terraform-provider-azurerm#24973 **New Resource**: `azurerm_dev_center_catalog` ([#24833](hashicorp/terraform-provider-azurerm#24833 **New Resource**: `azurerm_system_center_virtual_machine_manager_server` ([#24278](https://github.com/hashicorp/terraform-provider-azurerm/issues/24278))

BUG FIXES:

* `azurerm_key_vault` - conditionally polling the Data Plane endpoint when `public_network_access_enabled` is set to false ([#23823](hashicorp/terraform-provider-azurerm#23823 `azurerm_storage_account` - allow the `identity.type` property to be `SystemAssigned, UserAssigned` when using a Customer Managed Key ([#24923](hashicorp/terraform-provider-azurerm#24923 `azurerm_automation_account` - prevent the `identity.identity_ids` User Assigned identity being set when not specified in config ([#24977](https://github.com/hashicorp/terraform-provider-azurerm/issues/24977))

ENHANCEMENTS:

* dependencies: updating to `v0.20240221.1170458` of `hashicorp/go-azure-sdk` ([#24967](hashicorp/terraform-provider-azurerm#24967 dependencies: refactor `azurerm_spring_cloud_configuration_service` to use `go-azure-sdk` ([#24918](hashicorp/terraform-provider-azurerm#24918 provider: support or the feature flag `virtual_machine_scale_set.reimage_on_manual_upgrade` ([#22975](hashicorp/terraform-provider-azurerm#22975 `sentinel`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24962](hashicorp/terraform-provider-azurerm#24962 `sqlvirtualmachines`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24912](hashicorp/terraform-provider-azurerm#24912 `nginx` : updating to use `2024-01-01-preview` ([#24868](hashicorp/terraform-provider-azurerm#24868 `azurerm_cosmosdb_account` - support for the `backup.tier` property ([#24595](hashicorp/terraform-provider-azurerm#24595 `azurerm_linux_virtual_machine` - the `virtual_machine_scale_set_id` proeprty can now be changed without creating a new resource ([#24768](hashicorp/terraform-provider-azurerm#24768 `azurerm_machine_learning_workspace` - support for the `managed_network.isolation_mode` property ([#24951](hashicorp/terraform-provider-azurerm#24951 `azurerm_private_dns_resolver_inbound_endpoint` - support the `static` value for the `private_ip_allocation_method` property ([#24952](hashicorp/terraform-provider-azurerm#24952 `azurerm_postgresql_flexible_server` - expose the `storage_tier` field ([#24892](hashicorp/terraform-provider-azurerm#24892 `azurerm_redis_cache` - support for the `preferred_data_persistence_auth_method` property ([#24370](hashicorp/terraform-provider-azurerm#24370 `azurerm_servicebus_namespace` - support for the `premium_messaging_partitions` property ([#24676](hashicorp/terraform-provider-azurerm#24676 `azurerm_windows_virtual_machine` - the `virtual_machine_scale_set_id` proeprty can now be changed without creating a new resource ([#24768](https://github.com/hashicorp/terraform-provider-azurerm/issues/24768))

BUG FIXES:

* `azurerm_cognitive_deployment` - the `version_upgrade_option` property can not be updated without creating a new resource ([#24922](hashicorp/terraform-provider-azurerm#24922 `azurerm_data_protection_backup_vault` - support or the `soft_delete` and `retention_duration_in_days` properties ([#24775](hashicorp/terraform-provider-azurerm#24775 `azurerm_data_factory_pipeline` - correctly handle incorrect header values ([#24921](hashicorp/terraform-provider-azurerm#24921 `azurerm_kusto_cluster` - `optimized_auto_scale` is now updated after `sku` has been updated ([#24906](hashicorp/terraform-provider-azurerm#24906 `azurerm_key_vault_certificate` - will now only update the `lifetime_action` of the certificate block unless otherwise required ([#24755](hashicorp/terraform-provider-azurerm#24755 `azurerm_linux_virtual_machine_scale_set` - correctly include `public_ip_prefix_id` during updates ([#24939](hashicorp/terraform-provider-azurerm#24939 `azurerm_postgresql_flexible_server` - the `customer_managed_key.key_vault_key_id` property is now required ([#24981](hashicorp/terraform-provider-azurerm#24981 `azurerm_nginx_deployment` - changing the `sku` property now creates a new resource ([#24905](hashicorp/terraform-provider-azurerm#24905 `azurerm_orchestrated_virtual_machine_scale_set` - the `disk_size_gb` and `lun` parameters of `data_disks` are optional now ([#24944](hashicorp/terraform-provider-azurerm#24944 `azurerm_storage_account` - change order of API calls to be GET-then-PUT ratehr then PATCHES ([#23935](hashicorp/terraform-provider-azurerm#23935 `azurerm_storage_account` - improve the validation around the `immutability_policy` being used with `blob_properties` ([#24938](hashicorp/terraform-provider-azurerm#24938 `azurerm_security_center_setting` - prevent a bug when name is `SENTINEL` ([#24497](hashicorp/terraform-provider-azurerm#24497 `azurerm_windows_virtual_machine_scale_set` - correctly include `public_ip_prefix_id` during updates ([#24939](https://github.com/hashicorp/terraform-provider-azurerm/issues/24939))




</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/19/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

…ashicorp#24278) * New Resource: azurerm_system_center_virtual_machine_manager_server * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code * update code

github-actions · 2024-04-22T02:09:51Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

neil-yechenwei added 8 commits November 23, 2023 20:46

New Resource: azurerm_system_center_virtual_machine_manager_server

68c3895

update code

2a1483a

update code

434be7a

update code

c4d2557

update code

3c35fca

update code

a39c5ec

update code

ff527a8

Merge remote-tracking branch 'upstream/main' into systemcentervirtual…

5489e8d

…machinemanagermanagementserver

neil-yechenwei marked this pull request as draft December 20, 2023 02:25

ms-zhenhua suggested changes Dec 20, 2023

View reviewed changes

github-actions bot added the waiting-response label Dec 20, 2023

update code

14231a0

github-actions bot removed the waiting-response label Dec 21, 2023

update code

8b231ce

neil-yechenwei requested a review from ms-zhenhua December 21, 2023 08:37

ms-zhenhua reviewed Dec 25, 2023

View reviewed changes

...s/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_server_resource.go Show resolved Hide resolved

website/docs/r/system_center_virtual_machine_manager_server.html.markdown Show resolved Hide resolved

github-actions bot added the waiting-response label Dec 25, 2023

Merge remote-tracking branch 'upstream/main' into systemcentervirtual…

4ee6d89

…machinemanagermanagementserver

github-actions bot added documentation dependencies size/XL waiting-response and removed waiting-response labels Dec 25, 2023

update code

0f5cfa9

github-actions bot removed the waiting-response label Dec 25, 2023

update code

214caa1

ms-zhenhua reviewed Dec 26, 2023

View reviewed changes

website/docs/r/system_center_virtual_machine_manager_server.html.markdown Outdated Show resolved Hide resolved

github-actions bot added the waiting-response label Dec 26, 2023

update code

1b231b0

neil-yechenwei marked this pull request as ready for review December 27, 2023 09:11

katbyte approved these changes Jan 4, 2024

View reviewed changes

katbyte reviewed Jan 4, 2024

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Jan 4, 2024

neil-yechenwei added 3 commits January 27, 2024 13:06

update code

39bcd56

update code

2c4efe0

update code

3b77b19

github-actions bot added the service/load-balancers label Jan 27, 2024

update code

a6d3858

github-actions bot added the waiting-response label Feb 18, 2024

update code

49450d2

github-actions bot added waiting-response and removed waiting-response labels Feb 18, 2024

update code

cfa93d9

github-actions bot removed the waiting-response label Feb 18, 2024

neil-yechenwei added 2 commits February 18, 2024 12:27

update code

d37887c

update code

85e68e0

katbyte merged commit 5d4c43b into hashicorp:main Feb 20, 2024
33 checks passed

github-actions bot added this to the v3.93.0 milestone Feb 20, 2024

katbyte added a commit that referenced this pull request Feb 20, 2024

Update CHANGELOG.md #24278

147fcc0

rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 21, 2024

Update CHANGELOG.md hashicorp#24278

e31c633

rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 29, 2024

Update CHANGELOG.md hashicorp#24278

d1c6663

github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_system_center_virtual_machine_manager_server` #24278

New Resource: `azurerm_system_center_virtual_machine_manager_server` #24278

neil-yechenwei commented Dec 19, 2023 •

edited

Loading

ms-zhenhua left a comment

neil-yechenwei commented Dec 21, 2023

katbyte left a comment

katbyte Jan 4, 2024

neil-yechenwei Jan 4, 2024 •

edited

Loading

katbyte Jan 8, 2024

neil-yechenwei Jan 9, 2024 •

edited

Loading

github-actions bot commented Apr 22, 2024

		if os.Getenv("ARM_TEST_CUSTOM_LOCATION_ID") == "" \|\| os.Getenv("ARM_TEST_FQDN") == "" \|\| os.Getenv("ARM_TEST_PORT") == "" \|\| os.Getenv("ARM_TEST_USERNAME") == "" \|\| os.Getenv("ARM_TEST_PASSWORD") == "" {
		t.Skip("Skipping as one of `ARM_TEST_CUSTOM_LOCATION_ID`, `ARM_TEST_FQDN`, `ARM_TEST_PORT`, `ARM_TEST_USERNAME`, `ARM_TEST_PASSWORD` was not specified")

New Resource: azurerm_system_center_virtual_machine_manager_server #24278

New Resource: azurerm_system_center_virtual_machine_manager_server #24278

Conversation

neil-yechenwei commented Dec 19, 2023 • edited Loading

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Dec 21, 2023

katbyte left a comment

Choose a reason for hiding this comment

katbyte Jan 4, 2024

Choose a reason for hiding this comment

neil-yechenwei Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

katbyte Jan 8, 2024

Choose a reason for hiding this comment

neil-yechenwei Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Apr 22, 2024

New Resource: `azurerm_system_center_virtual_machine_manager_server` #24278

New Resource: `azurerm_system_center_virtual_machine_manager_server` #24278

neil-yechenwei commented Dec 19, 2023 •

edited

Loading

neil-yechenwei Jan 4, 2024 •

edited

Loading

neil-yechenwei Jan 9, 2024 •

edited

Loading