-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_windows_web_app
, azurerm_windows_web_app_slot
, azurerm_linux_web_app
, azurerm_linux_web_app_slot
, azurerm_windows_function_app
, azurerm_windows_function_app_slot
, azurerm_linux_function_app
, azurerm_linux_function_app_slot
- add runtime update
#24073
Conversation
azurerm_windows_web_app
, azurerm_windows_web_app_slot
, azurerm_linux_web_app
, azurerm_linux_web_app_slot
, azurerm_windows_function_app
, azurerm_windows_function_app_slot
, azurerm_linux_function_app
, azurerm_linux_function_app_slot
, azurerm_windows_web_app
, azurerm_windows_web_app_slot
, azurerm_linux_web_app
, azurerm_linux_web_app_slot
, azurerm_windows_function_app
, azurerm_windows_function_app_slot
, azurerm_linux_function_app
, azurerm_linux_function_app_slot
- add runtime update
Came here looking to implement 20-lts, Thanks Friends! |
@xiaxyi Is there anything blocking this being merged in the next patch version? It's been open for a bit. |
We are also waiting on this. Any release date in sight? |
We are also waiting on this. Is there an update on when this will be merged? |
What's the update for this? Neither 18-lts nor 20-lts work. |
Now that the API has been updated can you please resolve the conflicts here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the tests:
------- Stdout: -------
=== RUN TestAccLinuxWebApp_requiresImport
=== PAUSE TestAccLinuxWebApp_requiresImport
=== CONT TestAccLinuxWebApp_requiresImport
testcase.go:113: Step 1/2 error: Error running apply: exit status 1
Error: creating App Service Plan (Subscription: "*******"
Resource Group Name: "acctestRG-240209200140996370"
Server Farm Name: "acctestASP-240209200140996370"): performing CreateOrUpdate: unexpected status 409 with response: {"Code":"Conflict","Message":"The pricing tier 'Basic' is not allowed in this resource group. Use this link to learn more: https://aka.ms/app-service-plan-scale-not-allowed","Target":null,"Details":[{"Message":"The pricing tier 'Basic' is not allowed in this resource group. Use this link to learn more: https://aka.ms/app-service-plan-scale-not-allowed"},{"Code":"Conflict"},{"ErrorEntity":{"ExtendedCode":"04114","MessageTemplate":"The pricing tier '{0}' is not allowed in this resource group. Use this link to learn more: https://aka.ms/app-service-plan-scale-not-allowed","Parameters":["Basic"],"Code":"Conflict","Message":"The pricing tier 'Basic' is not allowed in this resource group. Use this link to learn more: https://aka.ms/app-service-plan-scale-not-allowed"}}],"Innererror":null}
with azurerm_service_plan.test,
on terraform_plugin_test.tf line 28, in resource "azurerm_service_plan" "test":
28: resource "azurerm_service_plan" "test" {
creating App Service Plan (Subscription:
"*******"
Resource Group Name: "acctestRG-240209200140996370"
Server Farm Name: "acctestASP-240209200140996370"): performing
CreateOrUpdate: unexpected status 409 with response:
{"Code":"Conflict","Message":"The pricing tier 'Basic' is not allowed in this
resource group. Use this link to learn more:
https://aka.ms/app-service-plan-scale-not-allowed","Target":null,"Details":[{"Message":"The
pricing tier 'Basic' is not allowed in this resource group. Use this link to
learn more:
https://aka.ms/app-service-plan-scale-not-allowed"},{"Code":"Conflict"},{"ErrorEntity":{"ExtendedCode":"04114","MessageTemplate":"The
pricing tier '{0}' is not allowed in this resource group. Use this link to
learn more:
https://aka.ms/app-service-plan-scale-not-allowed","Parameters":["Basic"],"Code":"Conflict","Message":"The
pricing tier 'Basic' is not allowed in this resource group. Use this link to
learn more:
https://aka.ms/app-service-plan-scale-not-allowed"}}],"Innererror":null}
--- FAIL: TestAccLinuxWebApp_requiresImport (105.96s)
FAIL
Thanks @katbyte for the review, tests are good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiaxyi - This LGTM 👍
Test failure due to service, not PR change.
<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.95.0" to "3.96.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.96.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.96.0
ENHANCEMENTS:

* dependencies: updating to `v0.20240314.1083835` of `github.com/hashicorp/go-azure-sdk` ([#25255](https://github.com/hashicorp/terraform-provider-azurerm/issues/25255))
* dependencies: updating to `v0.25.1` of `github.com/tombuildsstuff/giovanni` ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* dependencies: updating to `v1.33.0` of `google.golang.org/protobuf` ([#25243](https://github.com/hashicorp/terraform-provider-azurerm/issues/25243))
* `storage`: updating the data plane resources to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* Data Source: `azurerm_storage_table_entities` - support for AAD authentication ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* Data Source: `azurerm_storage_table_entity` - support for AAD authentication ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* `azurerm_kusto_cluster` - support `None` pattern for the `virtual_network_configuration` block ([#24733](https://github.com/hashicorp/terraform-provider-azurerm/issues/24733))
* `azurerm_linux_function_app` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))
* `azurerm_linux_function_app_slot` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))
* `azurerm_stack_hci_cluster` - support the `identity`, `cloud_id`, `service_endpoint` and `resource_provider_object_id` properties [GH-25031]
* `azurerm_storage_share_file` - support for AAD authentication ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* `azurerm_storage_share_directory` - support for AAD authentication, deprecate `share_name` and `storage_account_name` in favor of `storage_share_id` ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* `azurerm_storage_table_entity` - support for AAD authentication, deprecate `share_name` and `storage_account_name` in favor of `storage_table_id` ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* `azurerm_storage_table_entity` - support for AAD authentication ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* `azurerm_windows_function_app` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))
* `azurerm_windows_function_app_slot` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))
* `azurerm_windows_web_app` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))
* `azurerm_windows_web_app_slot` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))

BUG FIXES:

* `azurerm_container_app_custom_domain` - fix resource ID parsing bug preventing import ([#25192](https://github.com/hashicorp/terraform-provider-azurerm/issues/25192))
* `azurerm_windows_web_app` - fix incorrect warning message when checking name availability ([#25214](https://github.com/hashicorp/terraform-provider-azurerm/issues/25214))
* `azurerm_virtual_machine_run_command` - prevent a bug during updates ([#25186](https://github.com/hashicorp/terraform-provider-azurerm/issues/25186))
* Data Source: `azurerm_storage_table_entities` - Fix `items.x.properties` truncating to one entry ([#25211](https://github.com/hashicorp/terraform-provider-azurerm/issues/25211))</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/52/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
azurerm_windows_web_app
,azurerm_windows_web_app_slot
: add~20
fornode_version
inapplication_stack
azurerm_linux_web_app
,azurerm_linux_web_app_slot
: add8.0
fordotnet_version
&20-lts
fornode_version
inapplication_stack
azurerm_windows_function_app
,azurerm_windows_function_app_slot
: add~20
fornode_version
inapplication_stack
azurerm_linux_function_app
,azurerm_linux_function_app_slot
: add20
fornode_version
inapplication_stack
resolve issue:#23528